μ, ä, ö, å, emoji not accurately displayed in popup menus + saving problem

[sagantech]

Describe the bug
Incorrect characters appear in popup.

To Reproduce
Steps to reproduce the behavior:

1. Go to surge,
2. Click on preset
3. Scroll down to monosynth
4. See the last item in popup menu is incorrect and starts with weird character and should be "μcomputer"

This appears to be a bug in VSTGUI and can be fixed by changing:
MultiByteToWideChar (CP_UTF8 , 0, utf8Str, numCharacters, allocWideStr, numChars) to:
MultiByteToWideChar (CP_ACP, 0, utf8Str, numCharacters, allocWideStr, numChars)

Expected behavior
I would expect to see proper characters in popup menus.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [Windows 7]
• Host [Metro]
• Version [7.3]

[esaruoho]

Posted on Slack by @sagantech, here is Stefan Hållén which turns into UTF8 nonsense when viewed on windows.

[esaruoho]

this does not happen with Logic, macOS Mojave, AudioUnit - looks okay to me

same with the ucomputer one

[esaruoho]

Two important things:

1. With Mac, you can load patches within the Stefan Hållén -folder, and they load okay. You cannot Store into that folder/category.
2. With Mac, you can access and load a patch with an emoji in the folder, and they load okay, but you cannot Store into that folder/category.

[baconpaul]

Heya @sagantech I'm going about applying your diffs to our fork. Which of the MultiByteToChars did you change? All of them or one particular one? Thanks!

[sagantech]

I think you can safely change all of them although when I did it, I only changed the ones that I saw were producing bad results.

[baconpaul]

Thanks.

As you maybe saw, my first cut at the vstgui fork only included one of your changes. If we agree the way I did it was the way we want to proceed, I can sweep in these others quickly and also send them as pull requests to steinberg.

[sagantech]

I have a new one. I need to create an issue for it but after a popup vstgui calls the invalidate procedure before calling the callback which I think is really weird. Anyway it usually has no bad affect on Surge but in the case where the host audio engine is off, or doing something else, Surge does not display the correct value selected for a popup (waveform/window/etc.) until you select it twice.

[baconpaul]

Cool. We are close to having our patch factory up and running. Another issue is best yes. If possible including the changes you make in diff format or with line numbers would make them much easier to apply. Thank you!