CMD (mac) / CTRL (windows) will revert StepSeq LFO to Sine LFO when clicking on StepSeq display with CMD/CTRL down #376
Comments
|
it appears that this action is linked to the overall action of "control click" restting to 0 value .. i would assume in this case .. 0 value = Sine wave setting on the LFO wave selection area.. I would suggest this, whilst useful on a slider.. to reset its value to 0, is not needed at all on an LFO selection.. and could easily cause confusion and misunderstanding.. again.. an example of something within the code, i presume.. that works well in some areas.. but isnt needeed at all and isnt useful in others.. |
|
@sense-amr the behavior I see at head is 1: shift and control double click returns you to sine when clicking on the graphic of the picture both weird but want to make sure you see what I do. The control double click matches what happens on sliders too. But on sliders a double click without any modifier held also returns you to zero. And alt click returns you to zero also. |
esaruoho
changed the title
|
from my end on RenoiseVST2, it works like this: so slightly different behaviour from windows. anyway. clarified the title a bit |
|
@sense-amr your diagnosis is absolutely right. This is the "set default value on double click or control click" code path doing the wrong thing on this element. The code in question is the "else { p->set_value_f01(p->get_default_value" around like 1917 of SurgeGUIEditor.cpp. |
The LFO display (the wav) handles double click and ctrl click like any other control - reset to default value. That's really bad in the LFO display though, since if you ccidentally control click or double click on your step sequencer you go back to sin. So supress this gesture for ct_lfoshape. Closes surge-synthesizer#376
|
Anyway I have a fix. Will sweep it in when the auto builds are done and close this issue. |
The LFO display (the wav) handles double click and ctrl click like any other control - reset to default value. That's really bad in the LFO display though, since if you ccidentally control click or double click on your step sequencer you go back to sin. So supress this gesture for ct_lfoshape. Closes #376
The LFO display (the wav) handles double click and ctrl click like any other control - reset to default value. That's really bad in the LFO display though, since if you ccidentally control click or double click on your step sequencer you go back to sin. So supress this gesture for ct_lfoshape. Closes surge-synthesizer#376 Former-commit-id: 82b39534a0094893baa7fd834f929d84927c9029 [formerly d7cdf68] Former-commit-id: cbfc59ca0b546c93efb6110dacd6dff4487e8d2d Former-commit-id: de683be145562b4cb2c51122c34a89243c306995
Pressing inside the selected LFO shape display whilst holding control results in an immediate snap back to Sine Wave LFO shape..
Control LFO click reset to Sine.zip
The text was updated successfully, but these errors were encountered: