Don't resize larger than screen #369
Labels
UI
Issues related to UI look&feel
Comments
|
OK so I resisted adding a DisplayInfo.h before but now I will since it would have two functions rather than one. |
|
@esaruoho I have a preliminary fix for this on branch bacon paul / screensize-369 I want to do a few things still (like do a self-code-review, test win and lin still work, and squash) but if you want to try that on your mac and provide any feedback it would be great. I have a 2 monitor setup and it worked fine detecting the right monitor and stuff but these graphics APIs can be fiddly so another test would be lovely. Thank you! |
baconpaul
added a commit
to baconpaul/surge
that referenced
this issue
Jan 21, 2019
The current implementation will let you zoom to a size much larger than your screen, a change which you can't undo. Reported in surge-synthesizer#369. To resolve this, query the screen size at zoom time. Querying the screen size means I added (in this diff) DisplayInfo.h which is an implementation of functions in Surge::GUI namespace to get backing scale and screen size for the screen in which your current frame is resident (or if you are split screen, the screen the OS determines is the actually 'screen' for your window). Implemented in same cross platform style as UserInteractions. We then call that with a check and clear error message in SurgeGUIEditor
Merged
baconpaul
added a commit
to baconpaul/surge
that referenced
this issue
Jan 22, 2019
The current implementation will let you zoom to a size much larger than your screen, a change which you can't undo. Reported in surge-synthesizer#369. To resolve this, query the screen size at zoom time. Querying the screen size means I added (in this diff) DisplayInfo.h which is an implementation of functions in Surge::GUI namespace to get backing scale and screen size for the screen in which your current frame is resident (or if you are split screen, the screen the OS determines is the actually 'screen' for your window). Implemented in same cross platform style as UserInteractions. We then call that with a check and clear error message in SurgeGUIEditor Incorporate @jsakkine review comments
baconpaul
added a commit
to baconpaul/surge
that referenced
this issue
Jan 22, 2019
The current implementation will let you zoom to a size much larger than your screen, a change which you can't undo. Reported in surge-synthesizer#369. To resolve this, query the screen size at zoom time. Querying the screen size means I added (in this diff) DisplayInfo.h which is an implementation of functions in Surge::GUI namespace to get backing scale and screen size for the screen in which your current frame is resident (or if you are split screen, the screen the OS determines is the actually 'screen' for your window). Implemented in same cross platform style as UserInteractions. We then call that with a check and clear error message in SurgeGUIEditor Incorporate @jsakkine review comments
|
OK this is all swept into master. Thanks for the eagle eyes, @esaruoho! Hope you like the error message when you try to over-grow :) |
baconpaul
added a commit
to baconpaul/surge
that referenced
this issue
Jan 22, 2019
The current implementation will let you zoom to a size much larger than your screen, a change which you can't undo. Reported in surge-synthesizer#369. To resolve this, query the screen size at zoom time. Querying the screen size means I added (in this diff) DisplayInfo.h which is an implementation of functions in Surge::GUI namespace to get backing scale and screen size for the screen in which your current frame is resident (or if you are split screen, the screen the OS determines is the actually 'screen' for your window). Implemented in same cross platform style as UserInteractions. We then call that with a check and clear error message in SurgeGUIEditor
baconpaul
added a commit
to baconpaul/surge
that referenced
this issue
Jul 10, 2019
The current implementation will let you zoom to a size much larger than your screen, a change which you can't undo. Reported in surge-synthesizer#369. To resolve this, query the screen size at zoom time. Querying the screen size means I added (in this diff) DisplayInfo.h which is an implementation of functions in Surge::GUI namespace to get backing scale and screen size for the screen in which your current frame is resident (or if you are split screen, the screen the OS determines is the actually 'screen' for your window). Implemented in same cross platform style as UserInteractions. We then call that with a check and clear error message in SurgeGUIEditor Incorporate @jsakkine review comments Former-commit-id: c99446c99160cefff83d05cf2dedac863780d010 [formerly c47ccad] Former-commit-id: b57468500ad9eb388dd84a6bb017f957aed8bb4a Former-commit-id: a8d35c165f97553c37c609a9547c5d98a93e58ef
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
path to zoom #305
currently if i have a smaller screen and set to 300%, i cannot re-resize it to lower size, instead i'm stuck and need to delete the plugin and re-open it.
The text was updated successfully, but these errors were encountered: