Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows Installer doesn't clean up %PROGRAMDATA%\Surge #3427

Closed
baconpaul opened this issue Dec 14, 2020 · 3 comments · Fixed by #3750
Closed

Windows Installer doesn't clean up %PROGRAMDATA%\Surge #3427

baconpaul opened this issue Dec 14, 2020 · 3 comments · Fixed by #3750
Labels
Bug Report Item submitted using the Bug Report template Infrastructure Issues related to repository, CI/CD, installers, etc. Windows Windows related issues
Milestone
1.9.0

Comments

@baconpaul
Copy link
Collaborator

Over in #3423 we found that if you remove a file from a skin the installer doesn't clean it up on next install. The windows installer right now only cleans up patches basically.

We fixed that one by adding the deleted image and that's the conservative choice this late in the 18 cycle, but in 19 have a better strategy, perhaps even just InstallDelet'ing all of %PROGRAMDATA%\Surge.
@baconpaul baconpaul added the Bug Report Item submitted using the Bug Report template label Dec 14, 2020
@baconpaul baconpaul added this to the 1.9.0 milestone Dec 14, 2020
@mkruselj mkruselj added Infrastructure Issues related to repository, CI/CD, installers, etc. Windows Windows related issues labels Dec 23, 2020
@mkruselj mkruselj mentioned this issue Dec 29, 2020
Closed
@baconpaul
Copy link
Collaborator Author

So @mkruselj what's the verdict?

1: make win like mac and lin and blow away all of surge on an install
2: make win different than mac and lin and maintain a list of all the directories other than tuning-library and blow that away on an install?

@mkruselj
Copy link
Collaborator

Yeah I think 2, Blow away everything except tunings.

@baconpaul
Copy link
Collaborator Author

OK
So just add the list then and it will work

@mkruselj mkruselj changed the title Windows Installer doesn't clean up %PGDAT%\Surge Windows Installer doesn't clean up %PROGRAMDATA%\Surge Jan 29, 2021
@mkruselj mkruselj mentioned this issue Jan 29, 2021
Merged
mkruselj added a commit that referenced this issue Jan 29, 2021
@mkruselj
Clean up %PROGRAM_DATA\Surge before installing on Windows (#3750)
c4a3029 
Closes #3427
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template Infrastructure Issues related to repository, CI/CD, installers, etc. Windows Windows related issues
Projects
None yet
Milestone
1.9.0
Development

Successfully merging a pull request may close this issue.

Clean up %PROGRAM_DATA\Surge before installing on Windows
2 participants
@mkruselj @baconpaul