Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mono mode: note priorities #3359

Closed
mkruselj opened this issue Dec 6, 2020 · 4 comments · Fixed by #3362
Closed

Mono mode: note priorities #3359

mkruselj opened this issue Dec 6, 2020 · 4 comments · Fixed by #3362
Labels
Feature Request New feature request MIDI MIDI support related
Milestone
1.8.0

Comments

@mkruselj
Copy link
Collaborator

mkruselj commented Dec 6, 2020

Currently, Surge uses last note priority when dealing with note ons, but curiously (and strangely) uses highest note priority for note offs (when releasing a note to older keys that are still held down).

Add note priority modes: Latest (should be the new default), Lowest, Highest, Legacy. The difference is that Legacy would retain current weird behavior, and Latest/Lowest/Highest would be consistent in how they are applied for both note ons and note offs.
@mkruselj mkruselj added Feature Request New feature request MIDI MIDI support related labels Dec 6, 2020
@mkruselj mkruselj added this to the 1.8.0 milestone Dec 6, 2020
@baconpaul
Copy link
Collaborator

Latest should only be default if streaming version is 15
Otherwise old sessions will render differently

@mkruselj
Copy link
Collaborator Author

mkruselj commented Dec 6, 2020

Yes ofc!

@mkruselj
Copy link
Collaborator Author

mkruselj commented Dec 6, 2020 •
edited
Loading

I'd do it like this, not put them in a submenu:

image

Or in 1.9 we can make note priority its own control. We need to split up the play mode control into more than one parameter anyways (#679)...

@baconpaul
Copy link
Collaborator

Sure easy enough change.

baconpaul added a commit to baconpaul/surge that referenced this issue Dec 7, 2020
@baconpaul
Mono Voice Priority Modes
1e5bf6c 
This adds 3 new voice prioprity modes; always latest,highest, and lowest,
and adjusts the regular and MPE voice management to respect them.
It adds a collection of assertive regtests which test it, streams it
into the patch, and adds it to the UI.

Closes surge-synthesizer#3359
@baconpaul baconpaul mentioned this issue Dec 7, 2020
Merged
baconpaul added a commit to baconpaul/surge that referenced this issue Dec 7, 2020
@baconpaul
Mono Voice Priority Modes
759b2d7 
This adds 3 new voice prioprity modes; always latest,highest, and lowest,
and adjusts the regular and MPE voice management to respect them.
It adds a collection of assertive regtests which test it, streams it
into the patch, and adds it to the UI.

Closes surge-synthesizer#3359
baconpaul added a commit that referenced this issue Dec 7, 2020
@baconpaul
Mono Voice Priority Modes (#3362)
3f66c20 
This adds 3 new voice prioprity modes; always latest,highest, and lowest,
and adjusts the regular and MPE voice management to respect them.
It adds a collection of assertive regtests which test it, streams it
into the patch, and adds it to the UI.

Closes #3359
@mkruselj mkruselj added this to the 1.8.0 milestone Jan 18, 2021
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request New feature request MIDI MIDI support related
Projects
None yet
Milestone
1.8.0
Development

Successfully merging a pull request may close this issue.

Mono Voice Priority Modes baconpaul/surge
2 participants
@mkruselj @baconpaul