Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The misguided overlay tag API #3223

Closed
baconpaul opened this issue Nov 24, 2020 · 0 comments · Fixed by #3630
Closed

The misguided overlay tag API #3223

baconpaul opened this issue Nov 24, 2020 · 0 comments · Fixed by #3630
Labels
Code Refactoring General code refactoring and cleanup issues like names, unused variables, warnings, fixme
Milestone
1.9.0

Comments

@baconpaul
Copy link
Collaborator

overlay tag is a string where we compare with literals all over the code base.

It's fine for the small use cases in 18 but is obviously a crap API

Fix this early in 19
@baconpaul baconpaul added the Bug Report Item submitted using the Bug Report template label Nov 24, 2020
@baconpaul baconpaul added this to the 1.9.0 milestone Nov 24, 2020
@mkruselj mkruselj added Code Refactoring General code refactoring and cleanup issues like names, unused variables, warnings, fixme and removed Bug Report Item submitted using the Bug Report template labels Nov 24, 2020
@baconpaul baconpaul mentioned this issue Dec 15, 2020
Open
@mkruselj mkruselj mentioned this issue Dec 29, 2020
Closed
baconpaul added a commit to baconpaul/surge that referenced this issue Jan 14, 2021
@baconpaul
A structured multi-overlay API
3953a62 
editorOverlay is now a list so you can have multiple, and the
tags which identify it are an enum so you know the overlay classes
and can write less buggy code, and generallly everything is better.

Although there is inevitably more work we want to do on overlays
and positioning, this commit makes the API a good enough starting
point to add other overlays, so it Closes surge-synthesizer#3223
@baconpaul baconpaul mentioned this issue Jan 14, 2021
Merged
baconpaul added a commit to baconpaul/surge that referenced this issue Jan 27, 2021
@baconpaul
A structured multi-overlay API
913341f 
editorOverlay is now a list so you can have multiple, and the
tags which identify it are an enum so you know the overlay classes
and can write less buggy code, and generallly everything is better.

Although there is inevitably more work we want to do on overlays
and positioning, this commit makes the API a good enough starting
point to add other overlays, so it Closes surge-synthesizer#3223
baconpaul added a commit that referenced this issue Jan 27, 2021
@baconpaul
A structured multi-overlay API (#3630)
c716420 
editorOverlay is now a list so you can have multiple, and the
tags which identify it are an enum so you know the overlay classes
and can write less buggy code, and generallly everything is better.

Although there is inevitably more work we want to do on overlays
and positioning, this commit makes the API a good enough starting
point to add other overlays, so it Closes #3223
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Code Refactoring General code refactoring and cleanup issues like names, unused variables, warnings, fixme
Projects
None yet
Milestone
1.9.0
Development

Successfully merging a pull request may close this issue.

1.8.2 MERGEABLE - A structured multi-overlay API baconpaul/surge
2 participants
@mkruselj @baconpaul