Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Make it possible to copy and paste effect slot content from one effect slot to the other #309

Closed
esaruoho opened this issue Jan 15, 2019 · 22 comments · Fixed by #951
Closed

Feature Request: Make it possible to copy and paste effect slot content from one effect slot to the other #309

esaruoho opened this issue Jan 15, 2019 · 22 comments · Fixed by #951
Labels
Feature Request New feature request
Milestone
1.6.2

Comments

@esaruoho
Copy link
Collaborator

Problem:
I have a really nice effect going on in FX2. But it needs to be in A Insert 2. How do I "move" or copy-paste it from Send FX2 to A Insert 2? There's no way.

Solution:
Enable Copy / Paste of effect slots. Somehow.
@esaruoho esaruoho changed the title Make it possible to copy and paste effect chain from one effect chain slot to the other Feature Request: Make it possible to copy and paste effect chain from one effect chain slot to the other Jan 15, 2019
@esaruoho esaruoho changed the title Feature Request: Make it possible to copy and paste effect chain from one effect chain slot to the other Feature Request: Make it possible to copy and paste effect slot content from one effect slot to the other Jan 15, 2019
@esaruoho esaruoho mentioned this issue Jan 29, 2019
Closed
@baconpaul
Copy link
Collaborator

So this is a bit aggravating code wise, but before even surmounting that problem: What should the UX be like.

Imagine I can generate a copy and paste method. Cool. What actual gesture would you want to do?

I thought about RMB menu on the effect area but Right Mouse already disables an effect. There's no place to put copy in the per-effect views really. So what should this actually look like?

If I knew that, the coding wouldn't be impossible. But I don't quite know how to eve start this one.

The same problem impacts #378 so let me tag that here to link them.

@sense-amr
Copy link
Contributor

"C" and "P" ? symbol ? on the FX area.. when selecting the box for the fx? .. or would it be when selected FROM the pull down ? ..

@sense-amr
Copy link
Contributor

@esaruoho @baconpaul is this working now ? since last master?

@baconpaul
Copy link
Collaborator

No none of this has been done. I just realized I didn't even know how to start it.

@sense-amr
Copy link
Contributor

Ok well i suggested a UI for it i guess a small "C" and "P" for copy and paste.. and a "S" too for save.. how to recall it would i guess have to be via a dialogue window same as the browser patch recall scenario ?

@esaruoho
Copy link
Collaborator Author

esaruoho commented Feb 2, 2019 •
edited
Loading

@sense-amr when the ticket is closed, then it has been worked on and has been fixed.

also, instead of adding miniscule C/P/S into the GUI -- what is stopping the rightmousebutton from being where the copy / paste / clear functions are located in?

that way there's no extra GUI work required.

@sense-amr
Copy link
Contributor

sense-amr commented Feb 2, 2019 •
edited
Loading

when the ticket is closed, then it has been worked on and has been fixed. what are you talking about ?
this ticket is still clearly marked as OPEN./.?

@esaruoho
Copy link
Collaborator Author

esaruoho commented Feb 2, 2019

@sense-amr your original question: "is this working now ? since last master?"

answer: when the ticket is closed, then it has been fixed and is working. ergo, if ticket is not closed, it is "not working now since last master", because it has not been worked on.

tickets get closed when they have been done, are working, and in the master.

@baconpaul
Copy link
Collaborator

The rmb disables right now.

@baconpaul baconpaul added this to the 1.6.n milestone Feb 24, 2019
@baconpaul baconpaul mentioned this issue Apr 1, 2019
Closed
@baconpaul baconpaul modified the milestones: 1.6.n, 1.6.2 Jul 6, 2019
@baconpaul
Copy link
Collaborator

Screen Shot 2019-07-10 at 9 20 09 PM

Oh the obvious place to put copy and paste gestures is on the selection menu. I don't know why I didn't think of that before.

So I can easily implement this now I have realized that.

@sense-amr
Copy link
Contributor

sense-amr commented Jul 11, 2019 via email

@sense-amr
Copy link
Contributor

sense-amr commented Jul 11, 2019 via email

@esaruoho
Copy link
Collaborator Author

Screen Shot 2019-07-10 at 9 20 09 PM

Oh the obvious place to put copy and paste gestures is on the selection menu. I don't know why I didn't think of that before.

So I can easily implement this now I have realized that.

this seems like the best place to have it in, i reckon. thanks!

@sense-amr
Copy link
Contributor

sense-amr commented Jul 11, 2019 via email

@esaruoho
Copy link
Collaborator Author

for reordering efx in the efx slots

@sense-amr
Copy link
Contributor

sense-amr commented Jul 11, 2019 via email

@esaruoho
Copy link
Collaborator Author

esaruoho commented Jul 11, 2019 •
edited
Loading

btw, the original ticket actually describes what the issue was, and why copy+paste is a good thing to have across slots.

to reiterate:

I have a really nice effect going on in FX2. But it needs to be in 
A Insert 2. How do I "move" or copy-paste it from Send FX2 
to A Insert 2? There's no way.

the effects go through eachother, as there are two fx banks.

@baconpaul
Copy link
Collaborator

Yeah that's exactly it. If you want to move FX in the routing position you don't have a way now.

Save FX independently is separate. I think there's an issue for that. If not I can add it.

@baconpaul
Copy link
Collaborator

@sense-amr you are thinking of #378 but I just bumped that into the 1.6.2 milestone since I had this UI revelation last night.

@baconpaul
Copy link
Collaborator

CopyPaste

There you go!

baconpaul added a commit to baconpaul/surge that referenced this issue Jul 11, 2019
@baconpaul
Implement Copy and Paste for FX
037c4f3 
There was no way to move an FX from one position (say the first
inline A slot) to another (like the second send). This change puts
"Copy" and "Paste" on the menu so you can move FX around.

Closes surge-synthesizer#309
@baconpaul baconpaul mentioned this issue Jul 11, 2019
Merged
@esaruoho
Copy link
Collaborator Author

Perfect!!

baconpaul added a commit that referenced this issue Jul 11, 2019
@baconpaul
Implement Copy and Paste for FX (#951)
a6b15cf 
There was no way to move an FX from one position (say the first
inline A slot) to another (like the second send). This change puts
"Copy" and "Paste" on the menu so you can move FX around.

Closes #309
@sense-amr
Copy link
Contributor

sense-amr commented Jul 11, 2019 via email

@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request New feature request
Projects
None yet
Milestone
1.6.2
Development

Successfully merging a pull request may close this issue.

Implement Copy and Paste for FX baconpaul/surge
3 participants
@sense-amr @esaruoho @baconpaul