Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Random and Freerun LFO trigger modes don't work when rate is deactivated #2289

Closed
VincyZed opened this issue Jul 5, 2020 · 1 comment · Fixed by #2293
Closed

Random and Freerun LFO trigger modes don't work when rate is deactivated #2289

VincyZed opened this issue Jul 5, 2020 · 1 comment · Fixed by #2293
Labels
Bug Report Item submitted using the Bug Report template Modulation Modulation related issues
Milestone
1.7.0

Comments

@VincyZed
Copy link
Collaborator

VincyZed commented Jul 5, 2020

Description
When I deactivate LFO rate, Random and Freerun trigger modes don't work, it always triggers at the Phase set by the Phase / Shuffle slider (except for Noise, random works when frozen. And S&H is always random).

Version
Latest nightly

Expected behavior
When deactivated and in Random mode, start phase should be random in the cycle like it is normally when rate is activated and after stay there.

When deactivated and in Freerun mode, start phase should correspond to the host's clock like it does normally when rate is activated, but after stay there as well.
@VincyZed VincyZed added Bug Report Item submitted using the Bug Report template Modulation Modulation related issues labels Jul 5, 2020
@baconpaul baconpaul added this to the 1.7 0 milestone Jul 5, 2020
@baconpaul
Copy link
Collaborator

Great - I have this fixed

It means (basically) that the LFO in random deactivated mode ignores the phase slider which is what we want. Just mentioning that for the manual.

baconpaul added a commit to baconpaul/surge that referenced this issue Jul 5, 2020
@baconpaul
LFO Phase Deactivation Freerun and Random
c63ecdc 
In Freerun and Random mode only reset phase at attack not
in every cycle, meaning the randomness stays and we don't
end up using the phase slider

Closes surge-synthesizer#2289
@baconpaul baconpaul mentioned this issue Jul 5, 2020
Merged
baconpaul added a commit that referenced this issue Jul 5, 2020
@baconpaul
LFO Phase Deactivation Freerun and Random (#2293)
c4aab24 
In Freerun and Random mode only reset phase at attack not
in every cycle, meaning the randomness stays and we don't
end up using the phase slider

Closes #2289
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template Modulation Modulation related issues
Projects
None yet
Milestone
1.7.0
Development

Successfully merging a pull request may close this issue.

LFO Phase Deactivation Freerun and Random baconpaul/surge
2 participants
@baconpaul @VincyZed