Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LFO modulation of Mixer levels doesn't accept typein values #2287

Closed
ghost opened this issue Jul 5, 2020 · 5 comments · Fixed by #2296
Closed

LFO modulation of Mixer levels doesn't accept typein values #2287

ghost opened this issue Jul 5, 2020 · 5 comments · Fixed by #2296
Labels
Bug Report Item submitted using the Bug Report template
Milestone
1.7.0

Comments

@ghost
Copy link

ghost commented Jul 5, 2020

Surge-NIGHTLY-2020-07-03-75f7bc1 | Win-10, VST3i

LFO modulation of Mixer levels doesn't accept typein values

Notice in the attached GIF, that not only are typeins not accepted, but attempting to typein values for the modulation range actually results in completely disabling the assigned LFO modulation-source to the Mixer level slider altogether.

Expected behavior is that since bipolar modulation works when assigning the LFO modulation-source to the Mixer slider and setting the modulation range manually, that typeins should be accepted and enable making refinements to the LFO modulation range after the initial range is manually configured by dragging the slider close to the desired depth.

LICEcap
@ghost ghost added the Bug Report Item submitted using the Bug Report template label Jul 5, 2020
@K0rrid0r
Copy link
Collaborator

K0rrid0r commented Jul 5, 2020

can confirm!

@baconpaul baconpaul added this to the 1.7 0 milestone Jul 5, 2020
@baconpaul
Copy link
Collaborator

Thanks!

@baconpaul
Copy link
Collaborator

Yup definitely confirmed. Cool. Lemme look.

@baconpaul
Copy link
Collaborator

And it's only a problem when a mixer level starts at -inf. Should be easy to find. Thanks as always for the excellent report. Stay tuned.

@baconpaul
Copy link
Collaborator

Yup indeed I dealt with the minimum case improperly. Fix inbound.

baconpaul added a commit to baconpaul/surge that referenced this issue Jul 5, 2020
@baconpaul
Modulating off of -inf dB had incorrect typein
9c8925d 
The clamp stopped an actual -inf but my math for
the modulation reversal didn't use that properly.

Closes surge-synthesizer#2287
@baconpaul baconpaul mentioned this issue Jul 5, 2020
Merged
baconpaul added a commit that referenced this issue Jul 5, 2020
@baconpaul
Modulating off of -inf dB had incorrect typein (#2296)
f795a2d 
The clamp stopped an actual -inf but my math for
the modulation reversal didn't use that properly.

Closes #2287
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template
Projects
None yet
Milestone
1.7.0
Development

Successfully merging a pull request may close this issue.

Modulating off of -inf dB had incorrect typein baconpaul/surge
2 participants
@baconpaul @K0rrid0r