LFO average points algorithm appears confusing by LFO EG attack and Amplitude

[K0rrid0r]

Describe the bug
LFO display average points in drawing is exposed broken by LFO EG attack

Example how to see it.

Please let us know your surge version
this exist as a thing in the Vector LFO mode.

[K0rrid0r]

some pictures showing strange behavior in the lfo draw algo, will comment more about this later on.

[baconpaul]

thank you - great use cases for a fix!

[mkruselj]

@baconpaul I think I found this one.

surge/src/common/gui/CLFOGui.cpp

Line 261 in 8112ecf

if (maxval - minval > 0.2)

It's this check here. Unsure why it's needed, if I just remove the else branch and remove the if it shows up really nicely, and I cannot see any adverse effects. What was the reason behind this condition here?

[baconpaul]

It makes square-ish and other discontinuous waves draw properly on windows 8 and some windows 10 systems

[mkruselj]

Hm, those seem just fine over here on my two W10 and an old W7 machine...

[baconpaul]

Right so it fixes a problem on windows forever ago. So either that problem has magically disappeared or it hasn’t and I don’t remember what it is. So our choices are

1: remove this, believe in magic, go forth
2: remove this, find the bug, reinstate this before 19
3: remove this, ship 19, have 19 be broken forever or
4: don’t remove this and fix it with juce

I’m neutral but of these think 4 and 2 are the best

[mkruselj]

Let's go with 2! I scanned all the closed tickets mentioning LFO and no word on drawing issue under certain Windows... If it pops up back again, we will know. But I bet we're on JUCE by then. 🙂

[mkruselj]

Actually just found the issue... #1438

Oh, but your fix is WITHIN the if > 0.2 condition... so that's why it still works even if I remove that condition!

[baconpaul]

Ok!