Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverb 2 predelay modulation bounds #2208

Closed
mkruselj opened this issue Jun 27, 2020 · 1 comment · Fixed by #2215
Closed

Reverb 2 predelay modulation bounds #2208

mkruselj opened this issue Jun 27, 2020 · 1 comment · Fixed by #2215
Labels
DSP Issues and feature requests related to sound generation in the synth Effects
Milestone
1.7.0

Comments

@mkruselj
Copy link
Collaborator

  1. Load Init (Dry) preset for Reverb 2
  2. Set predelay to max (2s)
  3. Assign macro 1 to it and set max modulation amount (goes to 64 seconds)

Stuff ensues.
@mkruselj mkruselj added DSP Issues and feature requests related to sound generation in the synth Effects labels Jun 27, 2020
@baconpaul baconpaul added this to the 1.7 0 milestone Jun 27, 2020
@baconpaul
Copy link
Collaborator

Top tip for bug reports. If "stuff ensues" is speaker destroying madness, please say that! :)

baconpaul added a commit to baconpaul/surge that referenced this issue Jun 27, 2020
@baconpaul
Fix a Reverb2 Pre-Delay out of bounds
49f02bd 
Reverb2 if you modulated pre-delay out of bounds very very far could
explode. Fix it in two ways. (1) if->while in wrap code in the delay
in case I miss a spot; (2) clamp the predelay to far less than the delay
line (to allow the diffusion to spread across the delay)

Closes surge-synthesizer#2208
@baconpaul baconpaul mentioned this issue Jun 27, 2020
Merged
baconpaul added a commit that referenced this issue Jun 27, 2020
@baconpaul
Fix a Reverb2 Pre-Delay out of bounds (#2215)
78c3aa9 
Reverb2 if you modulated pre-delay out of bounds very very far could
explode. Fix it in two ways. (1) if->while in wrap code in the delay
in case I miss a spot; (2) clamp the predelay to far less than the delay
line (to allow the diffusion to spread across the delay)

Closes #2208
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DSP Issues and feature requests related to sound generation in the synth Effects
Projects
None yet
Milestone
1.7.0
Development

Successfully merging a pull request may close this issue.

Fix a Reverb2 Pre-Delay out of bounds baconpaul/surge
2 participants
@mkruselj @baconpaul