-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cents values to Bend Depth ranges in extended mode #2192
Comments
Here's a proposal for implementation for @baconpaul (because I tried it in #3073 and failed spectacularly): Add extended mode for pitch bend range, which would enable both wider range (+/-96 semitones?), AND typing in floats instead of ints. |
gonna knock this one out |
Key insight here: so you can’t set sub cent bends but I also don’t have to rewrite the entire code to do an if on whether you are float or int stored and fix all the streaming and stuff I just have one if and a mul by 0.01 then make the UI have drag edit keys and shift drag edit cents for that mode probably still keep it out of XT1 especially since you can just use a formula modulator to do the same thing if you want more or less but will ponder that insight so knock it back in just in case my primary concern now is the ui and whether we have space to show 13.57 as a bend |
We do have the room to show 13.57. But -13.57 might be a bit tricky, but considering we redesign GUI for XT2 anyways it will be accounted for. |
We don’t actually need to show the - since it is labeled dn I can also reduce the font for the decimal part So now maybe this does make xt1 or maybe not want to look at code to decide |
Just took a second to look at the code |
If you extend PB you get fractional bends. You can type in cents or tuning fractions too in extended mode Closes surge-synthesizer#2192
If you extend PB you get fractional bends. You can type in cents or tuning fractions too in extended mode Closes surge-synthesizer#2192
If you extend PB you get fractional bends. You can type in cents or tuning fractions too in extended mode Closes #2192
Excerpted from Slack discussion:
Jacky
Is it possible to make Bend Depth ranges support floating point values?
Negative/positive implications of doing such?
If it were actually possible, and wouldn't interfere with the tuning library implementation, then, instantly, the first part of #2125 could be checked off the list.
Fantasy implementation of the above, might include Shift + LMB scrolling to specify precise semicents values...
And or typeins.
baconpaul
Where they are applied yes; where they are stored i would have to look
And yeah shift to scroll etc....
Don’t want to do it for 170 since I’m really trying to freeze new features but would be happy to look once we are stabilized. From my understanding of the code there is nothing that makes it fundamentally an int inside the synth engine. Can you add an issue?
The text was updated successfully, but these errors were encountered: