Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cents values to Bend Depth ranges in extended mode #2192

Closed
ghost opened this issue Jun 24, 2020 · 6 comments · Fixed by #5022
Closed

Add cents values to Bend Depth ranges in extended mode #2192

ghost opened this issue Jun 24, 2020 · 6 comments · Fixed by #5022
Labels
Before Beta If these are open we can't really call ourselves beta Modulation Modulation related issues UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Milestone

Comments

@ghost
Copy link

ghost commented Jun 24, 2020

Excerpted from Slack discussion:

Jacky
Is it possible to make Bend Depth ranges support floating point values?

Negative/positive implications of doing such?

If it were actually possible, and wouldn't interfere with the tuning library implementation, then, instantly, the first part of #2125 could be checked off the list.

image

Fantasy implementation of the above, might include Shift + LMB scrolling to specify precise semicents values...
And or typeins.

baconpaul
Where they are applied yes; where they are stored i would have to look

And yeah shift to scroll etc....

Don’t want to do it for 170 since I’m really trying to freeze new features but would be happy to look once we are stabilized. From my understanding of the code there is nothing that makes it fundamentally an int inside the synth engine. Can you add an issue?

@baconpaul baconpaul added this to the 1.7.n milestone Jun 24, 2020
@baconpaul baconpaul added the Modulation Modulation related issues label Jun 24, 2020
@ghost ghost changed the title Add floating point values to Bend Depth ranges | Post 1.7 FR... Add floating point values to Bend Depth ranges Jul 22, 2020
@mkruselj mkruselj modified the milestones: 1.8.n, 1.9.0 Oct 8, 2020
@mkruselj mkruselj modified the milestones: 1.9.0, Surge XT Jan 26, 2021
@mkruselj
Copy link
Collaborator

Here's a proposal for implementation for @baconpaul (because I tried it in #3073 and failed spectacularly):

Add extended mode for pitch bend range, which would enable both wider range (+/-96 semitones?), AND typing in floats instead of ints.

@mkruselj mkruselj added the UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. label Feb 26, 2021
@baconpaul
Copy link
Collaborator

gonna knock this one out

@baconpaul
Copy link
Collaborator

baconpaul commented Sep 5, 2021

Key insight here:
The int vs float is a pain in the butt
But let’s keep it an int and have extended mode
mean that pitch bend is in cents not keys

so you can’t set sub cent bends

but I also don’t have to rewrite the entire code to do an if on whether you are float or int stored and fix all the streaming and stuff

I just have one if and a mul by 0.01

then make the UI have drag edit keys and shift drag edit cents for that mode

probably still keep it out of XT1 especially since you can just use a formula modulator to do the same thing if you want more or less but will ponder that insight so knock it back in just in case

my primary concern now is the ui and whether we have space to show 13.57 as a bend

@mkruselj
Copy link
Collaborator

mkruselj commented Sep 5, 2021

We do have the room to show 13.57. But -13.57 might be a bit tricky, but considering we redesign GUI for XT2 anyways it will be accounted for.

@baconpaul
Copy link
Collaborator

We don’t actually need to show the - since it is labeled dn

I can also reduce the font for the decimal part

So now maybe this does make xt1 or maybe not

want to look at code to decide

@baconpaul baconpaul changed the title Add floating point values to Bend Depth ranges Add cents values to Bend Depth ranges in extended mode Sep 5, 2021
@baconpaul
Copy link
Collaborator

Just took a second to look at the code
Keep it an int and extend it to mean cents is a really easy change I think. Some edge cases with Max and min but totally doable so let me keep this one in xt1 for now.
With this and midi channel and if I finish up the tws port xt1 could accidentally be a pretty good microtonal release as well as everything else!

@baconpaul baconpaul added the Before Beta If these are open we can't really call ourselves beta label Sep 6, 2021
baconpaul added a commit to baconpaul/surge that referenced this issue Sep 7, 2021
If you extend PB you get fractional bends. You can type in
cents or tuning fractions too in extended mode

Closes surge-synthesizer#2192
baconpaul added a commit to baconpaul/surge that referenced this issue Sep 7, 2021
If you extend PB you get fractional bends. You can type in
cents or tuning fractions too in extended mode

Closes surge-synthesizer#2192
baconpaul added a commit that referenced this issue Sep 7, 2021
If you extend PB you get fractional bends. You can type in
cents or tuning fractions too in extended mode

Closes #2192
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Before Beta If these are open we can't really call ourselves beta Modulation Modulation related issues UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Projects
None yet
2 participants