Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Right click does not work in transparent mode on Feedback, Width and FM Depth #2063

Closed
K0rrid0r opened this issue Jun 8, 2020 · 6 comments · Fixed by #2064 or #2070
Closed

Right click does not work in transparent mode on Feedback, Width and FM Depth #2063

K0rrid0r opened this issue Jun 8, 2020 · 6 comments · Fixed by #2064 or #2070
Labels
UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.

Comments

@K0rrid0r
Copy link
Collaborator

K0rrid0r commented Jun 8, 2020 •
edited
Loading

Describe the bug
Right click does not work on transparent mode on Feedback, Width and FM Depth

It makes planning stuff worse as you need to put it in a 'on' state to for example type in a value, if wanted. Which will potentially affect what you work on sound wise when you don't want to.
@K0rrid0r K0rrid0r changed the title Right click does not work on transparent mode on Feedback, Width and FM Depth Right click does not work in transparent mode on Feedback, Width and FM Depth Jun 8, 2020
baconpaul added a commit to baconpaul/surge that referenced this issue Jun 8, 2020
@baconpaul
A variety of cleanups and backdowns
a41abb3 
Revert "Linux Transparenty Fix 1-of-2 (surge-synthesizer#2057)"
This reverts commit 83b5a1b.

Revert "Linux Transparency Workarounds; CSurgeSlider cleanup (surge-synthesizer#2060)"
This reverts commit c88548a.

Fix a Reverb2 Typo when doing limit range for stability which
disabled the lfdamp

Closes surge-synthesizer#2061
Closes surge-synthesizer#2062
Closes surge-synthesizer#2063
Means we still have work for surge-synthesizer#2053
@baconpaul baconpaul mentioned this issue Jun 8, 2020
Merged
baconpaul added a commit that referenced this issue Jun 8, 2020
@baconpaul
A variety of cleanups and backdowns (#2064)
7a5f33d 
Revert "Linux Transparenty Fix 1-of-2 (#2057)"
This reverts commit 83b5a1b.

Revert "Linux Transparency Workarounds; CSurgeSlider cleanup (#2060)"
This reverts commit c88548a.

Fix a Reverb2 Typo when doing limit range for stability which
disabled the lfdamp

Closes #2061
Closes #2062
Closes #2063
Means we still have work for #2053
@K0rrid0r
Copy link
Collaborator Author

K0rrid0r commented Jun 8, 2020

This is not fixed in Surge-NIGHTLY-2020-06-08-7a5f33d i just tried. Right click does not open a dialog window.

49

Windows issue, maybe.

@K0rrid0r
Copy link
Collaborator Author

K0rrid0r commented Jun 8, 2020

Double right click also has the function to put it back to init position (instead of dialog window)

50

@VincyZed
Copy link
Collaborator

VincyZed commented Jun 8, 2020

Yup, can confirm.

@baconpaul
Copy link
Collaborator

OK will look

@baconpaul baconpaul reopened this Jun 8, 2020
@baconpaul
Copy link
Collaborator

Oh sigh I tried it with Sine ones where it works and figured that was a fix; but there's another spot. Sorry bout that!

@baconpaul
Copy link
Collaborator 

      if ((button & kRButton) && !(p->ctrltype == ct_lfoshape) &&
          !(ctrl != nullptr && ctrl->disabled == true)) // supress RMB on LFO Shape and hidden sliders, for LFO let CLFOGui handle it

oh the code explicitly disables it!
lemme take that out

@mkruselj mkruselj added the UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. label Jun 8, 2020
baconpaul added a commit to baconpaul/surge that referenced this issue Jun 8, 2020
@baconpaul
Since we now shiw Disabled, allow them to RMB
6db6ec4 
Closes surge-synthesizer#2063
@baconpaul baconpaul mentioned this issue Jun 8, 2020
Merged
baconpaul added a commit that referenced this issue Jun 8, 2020
@baconpaul
Since we now shiw Disabled, allow them to RMB (#2070)
1203e56 
Closes #2063
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Projects
None yet
Milestone
No milestone
4 participants
@mkruselj @baconpaul @VincyZed @K0rrid0r