Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Envelope Type and External Automation #206

Closed
baconpaul opened this issue Jan 4, 2019 · 2 comments · Fixed by #1074
Closed

Envelope Type and External Automation #206

baconpaul opened this issue Jan 4, 2019 · 2 comments · Fixed by #1074
Labels
UI Issues related to UI look&feel
Milestone
1.6.2

Comments

@baconpaul
Copy link
Collaborator

After we fixed #160 which linked DAW parameter changes with GUI changes, only envelope type was left. envelope type is different from other params in that

  1. It sets need_refresh=true in SurgeSynthesizer so skips the idle refresh
  2. When using it in the GUI it also updates the picture of the ADSR envelope
  3. Those things aren't obvious how to link when coming from parameters

So while almost every parameter works, this one bug remains. I'm going to drop this here as a low priority UI bug.

If you want to figure out how to fix it here's how to diagnose

  1. bind your DAW to the scene a aeg filter mode. You can hear it changing but not see it.
  2. Then click on digital and analog and you can see and hear it changing but you also see the envelope image changing
  3. Then try setting needs_refresh=true in SurgeSytnehsizer like I did for solo and then the parameter works to change the switch
  4. but then neither the parameter nor the switch change the display of the envelope

So I can get it in a state with two different bugs but not in a state with zero bugs.
@baconpaul baconpaul added the UI Issues related to UI look&feel label Jan 4, 2019
@baconpaul baconpaul added this to the 1.6.0 milestone Feb 24, 2019
@lunafreya
Copy link

Uh, @baconpaul, did you resolve the envelope type bug you said in this issue? I think this might have been fixed in the later versions of the synth.

@baconpaul baconpaul modified the milestones: 1.6.0, 1.6.n Jun 10, 2019
@baconpaul baconpaul added this to the 1.6.2 milestone Jun 19, 2019
@baconpaul baconpaul modified the milestones: 1.6.2, 1.6.n Aug 13, 2019
@baconpaul baconpaul modified the milestones: 1.6.n, 1.6.2 Aug 22, 2019
@baconpaul
Copy link
Collaborator Author

Hey while working on #702 I found the solution to this one also.

baconpaul added a commit to baconpaul/surge that referenced this issue Aug 22, 2019
@baconpaul
Rebuild controls for a couple of special cases
cdcd18a 
When OSC type changes or envelope mode changes, the results are
really non-local. (OSC type lays out all the sliders again;
envelope mode changes the envelope control switches). To address
this we can force an editor rebuild when these are toggled, kind
of like we do with FX (although using a slightly different API)

Closes surge-synthesizer#206
Addresses part of surge-synthesizer#702
@baconpaul baconpaul mentioned this issue Aug 22, 2019
Merged
baconpaul added a commit that referenced this issue Aug 22, 2019
@baconpaul
Rebuild controls for a couple of special cases (#1074)
cb63753 
When OSC type changes or envelope mode changes, the results are
really non-local. (OSC type lays out all the sliders again;
envelope mode changes the envelope control switches). To address
this we can force an editor rebuild when these are toggled, kind
of like we do with FX (although using a slightly different API)

Closes #206
Addresses part of #702
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
UI Issues related to UI look&feel
Projects
None yet
Milestone
1.6.2
Development

Successfully merging a pull request may close this issue.

Rebuild controls for a couple of special cases baconpaul/surge
2 participants
@baconpaul @lunafreya