Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LFO deform problem, cross LFOing #2016

Closed
K0rrid0r opened this issue Jun 3, 2020 · 1 comment · Fixed by #2017
Closed

LFO deform problem, cross LFOing #2016

K0rrid0r opened this issue Jun 3, 2020 · 1 comment · Fixed by #2017

Comments

@K0rrid0r
Copy link
Collaborator

K0rrid0r commented Jun 3, 2020

Describe the bug
It is hard to locate what the cause of this problem is but when doing cross LFOing between for example two LFOs and involving deform surge sometimes breaks/stops/clips.

Please let us know your surge version
all versions from old to newest.

To Reproduce
Just take deform on LFO1 (SEQ 1) to over 50% and surge will break/stop/clip
surge breaks LFO1 deform 50%.zip

Just take deform on LFO1 (SEQ 1) to over 50% and surge will give a sound that indicates the problem but not break
surge breaks LFO1 deform 50% 2.zip

This one just breaks/stops/clips, directly when played.
surge broke 2.zip

Expected behavior
No break/stop/clip, when doing cross LFOing in interesting ways.

@baconpaul
Copy link
Collaborator

Found it. What an amazingly good bug report. Thank you.

baconpaul added a commit to baconpaul/surge that referenced this issue Jun 3, 2020
When LFOs modulate other LFOs especially their rates the phase
can go not only >1 but also >2 and then the -=1 takes too
long to come back down, causing random noise and glitches
(and things like cubic interpolation to 'phase 74' which tives
you modulators like '1e6'. Fix by using fmod in extreme cases.

CLoses surge-synthesizer#2016
baconpaul added a commit that referenced this issue Jun 3, 2020
When LFOs modulate other LFOs especially their rates the phase
can go not only >1 but also >2 and then the -=1 takes too
long to come back down, causing random noise and glitches
(and things like cubic interpolation to 'phase 74' which tives
you modulators like '1e6'. Fix by using fmod in extreme cases.

CLoses #2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants