Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes made through host automation to the Assignable controllers are not reflected in export/render/bounce (VST3) #1999

Closed
arjen-klar opened this issue Jun 1, 2020 · 6 comments · Fixed by #2134
Closed

Changes made through host automation to the Assignable controllers are not reflected in export/render/bounce (VST3) #1999

arjen-klar opened this issue Jun 1, 2020 · 6 comments · Fixed by #2134
Labels
Host Automation Issues related to DAW (host) automation VST3 VST3 plugin related issues
Milestone
1.7.0

Comments

@arjen-klar
Copy link

Describe the bug
Changes made to the Assignable controllers through DAW automation are not reflected in non real time DAW export/render/bounce. This only is applicable for the VST3 version.

Tested with Studio One 4.5 and Cubase 10.5

Please let us know your surge version
1.6.6
VST3
x64

To Reproduce
Steps to reproduce the behavior:

  1. Load Init preset
  2. Assign Assignable controller 1 (C1:) to OSC 1 pitch with a value of -7 on 100%
  3. Create a note and automation move in the host controlling Assignable controller 1 (C1:) from 0 to 100%
  4. Export the result (not in real time)

Expected behavior
The exports reflects what the DAW plays back in real time (pitch going from 0 to -7 (0 to 100%)

Desktop (please complete the following information):

  • OS: Windows 10
  • Host Studio One 4.5, Cubase 10.5
@baconpaul baconpaul added this to the 1.7 beta 1 milestone Jun 1, 2020
@baconpaul baconpaul added the VST3 VST3 plugin related issues label Jun 1, 2020
@baconpaul
Copy link
Collaborator

Oh fascinating Thank you for the excellent report

@baconpaul
Copy link
Collaborator

@mkruselj looked in reaper and same thing there. This is more of the “cc vs FX1” mapping confusion. I’ll try and hunt it down.

Appreciate the report.

@mkruselj mkruselj added the Host Automation Issues related to DAW (host) automation label Jun 1, 2020
@mkruselj
Copy link
Collaborator

mkruselj commented Jun 1, 2020

As a temporary workaround, you can use the MIDI CC assigned to the macro controller and it will work.

@baconpaul baconpaul mentioned this issue Jun 8, 2020
Closed
@baconpaul
Copy link
Collaborator

So confirmed. When I automate CC -> Pitch in the DAW it sounds but when I render it does not.

So let me find out what the difference is.

@baconpaul
Copy link
Collaborator

Found it. Far less scary than I thought. There are two entry points for automation and I had one of them skipping the metacontrollers

baconpaul added a commit to baconpaul/surge that referenced this issue Jun 17, 2020
@baconpaul
Macro Automation in Render Mode
8ead23c 
There's a few APIs to set a param in a VST3. setParamNormalized,
setParamAutomated, and processParameterChange(list). Funnily
Reaper calls setParamNormailzed in realtime playback mode and
processParameterChange(list) in render mode. But I had forgotten
to put in the special case for macros in processParameterChange
so they got dropped in reaper render. Fixed.

Closes surge-synthesizer#1999
@baconpaul baconpaul mentioned this issue Jun 17, 2020
Merged
baconpaul added a commit that referenced this issue Jun 17, 2020
@baconpaul
Macro Automation in Render Mode (#2134)
2035cf9 
There's a few APIs to set a param in a VST3. setParamNormalized,
setParamAutomated, and processParameterChange(list). Funnily
Reaper calls setParamNormailzed in realtime playback mode and
processParameterChange(list) in render mode. But I had forgotten
to put in the special case for macros in processParameterChange
so they got dropped in reaper render. Fixed.

Closes #1999
@baconpaul
Copy link
Collaborator

This will be fixed in the next surge nightly; and also in the upcoming 1.7 release later this summer.

@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Host Automation Issues related to DAW (host) automation VST3 VST3 plugin related issues
Projects
None yet
Milestone
1.7.0
Development

Successfully merging a pull request may close this issue.

Macro Automation in Render Mode baconpaul/surge
3 participants
@mkruselj @baconpaul @arjen-klar