Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag n Drop a Wav into Oscillator #199

Closed
baconpaul opened this issue Jan 4, 2019 · 1 comment
Closed

Drag n Drop a Wav into Oscillator #199

baconpaul opened this issue Jan 4, 2019 · 1 comment

Comments

@baconpaul
Copy link
Collaborator

@esaruoho had asked if you can drag and drop a sample into an oscillator window.

COscillatorDisplay.cpp has this code

bool COscillatorDisplay::onDrop(IDataPackage* drag, const CPoint& where)
{
   /*long size,type;
   char *filename = (char*)drag->first(size,type);
   //while(filename)
   if(filename)
   {
           if(type == CDragContainer::kFile)
           {
                   strncpy(oscdata->wt.queue_filename, filename, 255);
           }
//		filename = (char*)drag->next(size,type);
   }*/
   return true;
}

which looks like there was a start at an attempt at that. Don't think this is a release critical issue but a bit of work to pick up I stumbled across so wanted to drop it in an issue.

@baconpaul
Copy link
Collaborator Author

So I got the VSTGUI 4 drag n drop API in place and on my mac at least, I now get a filename printed to stderr when you drop any file onto the oscillator.

baconpaul branch drag-n-drop-199

baconpaul added a commit to baconpaul/surge that referenced this issue Jul 10, 2019
Implement .wt drag-n-drop. Closes surge-synthesizer#199 

Former-commit-id: a64b61bdd49b52abe62724f9fd651621a7e60ce2 [formerly aa6703c]
Former-commit-id: cca36a78d1111c6bf90dbefc230c5c3c624f31bc
Former-commit-id: 7349e5a520521ff37c8cfa940498bc9c1839f495
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant