Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

absolute extended lets you modulate into negative frequency #1847

Closed
baconpaul opened this issue May 9, 2020 · 2 comments · Fixed by #2139
Closed

absolute extended lets you modulate into negative frequency #1847

baconpaul opened this issue May 9, 2020 · 2 comments · Fixed by #2139
Labels
DSP Issues and feature requests related to sound generation in the synth Modulation Modulation related issues
Milestone
1.7.0

Comments

@baconpaul
Copy link
Collaborator

clip it at the 8.162 whatever frequency we use as the base of our tuning
@baconpaul baconpaul added DSP Issues and feature requests related to sound generation in the synth Modulation Modulation related issues labels May 9, 2020
@baconpaul baconpaul added this to the 1.7 beta 1 milestone May 9, 2020
@baconpaul baconpaul mentioned this issue Jun 13, 2020
Closed
@baconpaul baconpaul reopened this Jun 14, 2020
@baconpaul
Copy link
Collaborator Author

New Patch
LFO 1 -> Pitch 1 at around 4
Osc 1 -> sin
play note 48 or so
pitch -> absolute
play 48
pitch -> extended
play 48
blammo

@baconpaul
Copy link
Collaborator Author

Have this fixed. Gonna try and see if I can combine my fix with #2136 also tho

baconpaul added a commit to baconpaul/surge that referenced this issue Jun 17, 2020
@baconpaul
Fix some absolute modulation bugs
0252c37 
* You can extend and modulate to negative frequency. Cap. Closes surge-synthesizer#1847
* External modulation of note leads to correct solve if note is non-integral
  in surge voice tuning aware frequency shift finder. Closes surge-synthesizer#2136
@baconpaul baconpaul mentioned this issue Jun 17, 2020
Merged
baconpaul added a commit that referenced this issue Jun 17, 2020
@baconpaul
Fix some absolute modulation bugs (#2139)
6e6fd12 
* You can extend and modulate to negative frequency. Cap. Closes #1847
* External modulation of note leads to correct solve if note is non-integral
  in surge voice tuning aware frequency shift finder. Closes #2136
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DSP Issues and feature requests related to sound generation in the synth Modulation Modulation related issues
Projects
None yet
Milestone
1.7.0
Development

Successfully merging a pull request may close this issue.

Fix some absolute modulation bugs baconpaul/surge
1 participant
@baconpaul