Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl+drag always starts from default value #1844

Closed
mkruselj opened this issue May 9, 2020 · 3 comments · Fixed by #1862
Closed

Ctrl+drag always starts from default value #1844

mkruselj opened this issue May 9, 2020 · 3 comments · Fixed by #1862
Labels
UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Milestone

Comments

@mkruselj
Copy link
Collaborator

mkruselj commented May 9, 2020

Regardless of where the slider actually is, it seems that Ctrl+drag always first executes Ctrl+click, which defaults the control. This can be quite inconvenient, for example if the volume slider was at a low value, and its default value is 0 dB.

We already have defaulting controls on double-click, so Ctrl+click should just do nothing here.

@mkruselj mkruselj added the UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. label May 9, 2020
@baconpaul baconpaul added this to the 1.7 beta 1 milestone May 9, 2020
@mkruselj
Copy link
Collaborator Author

mkruselj commented May 9, 2020

Here's another tidbit of info: this only happens if you hold Ctrl first, THEN press mouse and drag. If you press mouse to drag and then add Ctrl, it doesn't jump (I guess makes sense, since the drag has already started?).

@baconpaul
Copy link
Collaborator

Yeah makes sense because drag starts with click and if Ctrl-click centers then...

@mkruselj
Copy link
Collaborator Author

One-liner change to fix it, amazing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants