Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sceneout scaled by amplitude #1813

Closed
baconpaul opened this issue May 7, 2020 · 0 comments · Fixed by #1816
Closed

sceneout scaled by amplitude #1813

baconpaul opened this issue May 7, 2020 · 0 comments · Fixed by #1816
Labels
DSP Issues and feature requests related to sound generation in the synth
Milestone
1.7.0

Comments

@baconpaul
Copy link
Collaborator

master volume is applied to mix but not scene a or scene b out. around line 2781 we can safely apply the multiply.
@baconpaul baconpaul added the DSP Issues and feature requests related to sound generation in the synth label May 7, 2020
@baconpaul baconpaul added this to the 1.7 beta 1 milestone May 7, 2020
baconpaul added a commit to baconpaul/surge that referenced this issue May 7, 2020
@baconpaul
MAster Volume Scale for VST3 Scene Outs
1f0f4d0 
The Master Volume was after the sceneout split, so apply that
and the hardclip to the sceneout temps jus tlike to master

Closes surge-synthesizer#1813
@baconpaul baconpaul mentioned this issue May 7, 2020
Merged
baconpaul added a commit that referenced this issue May 7, 2020
@baconpaul
MAster Volume Scale for VST3 Scene Outs (#1816)
99ba8ac 
The Master Volume was after the sceneout split, so apply that
and the hardclip to the sceneout temps jus tlike to master

Closes #1813
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DSP Issues and feature requests related to sound generation in the synth
Projects
None yet
Milestone
1.7.0
Development

Successfully merging a pull request may close this issue.

MAster Volume Scale for VST3 Scene Outs baconpaul/surge
1 participant
@baconpaul