-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
binaries and plugins have executable stack by default #1701
Comments
So @dvzrv this is easy to add of course but a quick google leads me to understand that on some older architectures where this isn't hardware supported there can be some performance penalties. Am I mis-understanding? (that is entirely possible. It's been a decade or more since I worried about this sort of thing on unixes) |
I think the performance penalty in relation to this is completely negliable. |
1. add the -z,noexecstack linker on gnu cc. Closes surge-synthesizer#1701 2. Add a surge-xt-standalone-run target for command line fun
next merge accomplishes that difference |
1. add the -z,noexecstack linker on gnu cc. Closes #1701 2. Add a surge-xt-standalone-run target for command line fun
Describe the bug
When building 1.6.6 as a package for Arch Linux I realized that created executables and plugins have executable stack. This can be circumvented by adding
-z,noexecstack
toLDFLAGS
.Please let us know your surge version
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Executables and plugins don't have executable stack.
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: