Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skin: Change area behind LFO waveform color #1635

Closed
itsmedavep opened this issue Mar 19, 2020 · 7 comments
Closed

Skin: Change area behind LFO waveform color #1635

itsmedavep opened this issue Mar 19, 2020 · 7 comments
Labels
Skinning Engine Issues related to Surge's skin engine

Comments

@itsmedavep
Copy link
Contributor

It would be great to be able to control the bg color of the area the LFO waveform draws on.
@itsmedavep
Copy link
Contributor Author

Screen Shot 2020-03-18 at 8 44 11 PM

@baconpaul baconpaul added the Skinning Engine Issues related to Surge's skin engine label Mar 19, 2020
@baconpaul
Copy link
Collaborator

Note to self: right now we don't even fill the component in vector mode so just ride along with the background. Add a color test for it and do a fillrect.

baconpaul added a commit to baconpaul/surge that referenced this issue Mar 19, 2020
@baconpaul
Implement "lfo.waveform.fill"
7efaeb8 
Color "lfo.waveform.fill" fills the waveform section of the LFO
display. Otherwise it is left transparent to the background.

Addresses surge-synthesizer#1635
@baconpaul baconpaul mentioned this issue Mar 19, 2020
Merged
@baconpaul
Copy link
Collaborator

Once I merge #1641 the color "lfo.waveform.fill" will do this. I also put it in the dark skin. If that works as you expect, please close this issue! Thanks!

@baconpaul
Copy link
Collaborator

Oh and from my dumb test skin, this is the part of the UI to which that color applies.

Screen Shot 2020-03-19 at 3 47 00 PM

baconpaul added a commit that referenced this issue Mar 19, 2020
@baconpaul
Implement "lfo.waveform.fill" (#1641)
789c5c1 
Color "lfo.waveform.fill" fills the waveform section of the LFO
display. Otherwise it is left transparent to the background.

Addresses #1635
@itsmedavep
Copy link
Contributor Author

Color change looks good. I do seem to get a little drawing oddness.

Screen Shot 2020-03-19 at 6 56 22 PM

I

@baconpaul
Copy link
Collaborator

Oh I bet that’s the attack envelope - I will look tomorrow

@itsmedavep
Copy link
Contributor Author

Oh yeah! It totally was and I didnt realize I had touched it. Closing out now

@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Skinning Engine Issues related to Surge's skin engine
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@itsmedavep @baconpaul