Rename Ctl1 without zenity installed breaks the gui

[magnetophon]

Describe the bug
When I click "rename Ctl1" the gui turns into this:

Then I did something with Surge that crashed Ardour. I forgot what I did, sorry.
When I reopen Ardour, create a new track, add Surge and open the gui, it's still broken.

The name of the function I clicked is from memory, as I don't have a working surge anymore.

Please let us know your surge version

• Surge Version: 1.6.6
• Plugin type: LV2
• Bits 64

To Reproduce
Steps to reproduce the behavior:

1. right click Ctl1
2. click "rename Ctl1"
3. See error

Desktop (please complete the following information):

• OS: NixOS
• Host: Ardour
• Version: 5.12

[baconpaul]

that rename pops up zenity
i just tried it on ubuntu 18 with the lv2 in ardour and it worked fine
did you get a small window popping up when you clicked rename?

I am not sure why it would permanently blow up your surge. perhaps start a fresh ardour session?

[magnetophon]

When I open a new ardour session, the gui works again.
The other session still doesn't; I can attach it if you want.

I ran Ardour from the cli, and got "zenity: command not found" when I tried to rename, that's almost certainly a NixOS thing.
No broken gui this time.

[baconpaul]

Nah no need

I bet the problem is here

surge/src/common/gui/PopupEditorDialog.cpp

Line 156 in a7da44c

snprintf(cmd, 1024, "zenity --entry --entry-text \"%s\"", c );

when zenity isn't found we leave garbage in the buffer.

Both those return branches should add a c[0] = 0; before the return. And that strncopy should be maxchars - 1