Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deb file has wrong ownership of files #1579

Closed
baconpaul opened this issue Feb 15, 2020 · 4 comments
Closed

deb file has wrong ownership of files #1579

baconpaul opened this issue Feb 15, 2020 · 4 comments
Labels
Linux Issues which only occur on Linux
Milestone
1.6.6

Comments

@baconpaul
Copy link
Collaborator

baconpaul commented Feb 15, 2020 •
edited
Loading

@bgins points out the deb file has some weird user id for the files it installs

image

According to https://askubuntu.com/questions/735883/what-user-file-owner-to-use-when-creating-debian-packages a reasonable answer is to modify installer_linux/make-deb.sh to add the option --root-owner-group to deb-dpkg at line 93.
@baconpaul baconpaul added the Linux Issues which only occur on Linux label Feb 15, 2020
@baconpaul baconpaul added this to the 1.6.6 milestone Feb 15, 2020
bgins added a commit to bgins/surge that referenced this issue Feb 15, 2020
@bgins
Update deb file ownerships
26dd9fa 
Add flag to dpkg-deb to make root the owner and group on installed files.
Addresses surge-synthesizer#1579.
@bgins bgins mentioned this issue Feb 15, 2020
Merged
@bgins
Copy link
Contributor

bgins commented Feb 15, 2020

I added the -root-owner-group flag and that worked out fine. When I tested it before the change, it was setting me as the user and group, so the user and group from the screenshot are probably from the build pipeline.

baconpaul pushed a commit that referenced this issue Feb 15, 2020
@bgins
Update deb file ownerships (#1580)
9bd282b 
Add flag to dpkg-deb to make root the owner and group on installed files.
Addresses #1579.
@baconpaul baconpaul reopened this Feb 15, 2020
@baconpaul
Copy link
Collaborator Author

So --root-owner-group doesn't exist on the deb in the azure pipeline. Back to drawing board. Probably need to investigate fake root (and apt-getting that in the pipeline).

Reverted the change for now.

@bgins
Copy link
Contributor

bgins commented Feb 16, 2020

The recent changes to the pipeline in surge-synthesizer/releases@d3e2a51 have this one resolved.

perms

@baconpaul
Copy link
Collaborator Author

Great!

@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Linux Issues which only occur on Linux
Projects
None yet
Milestone
1.6.6
Development

No branches or pull requests
2 participants
@bgins @baconpaul