Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C1-8 controls only report values 0-9 to host now (really: windows w_char sprintfs) #1553

Closed
mkruselj opened this issue Feb 5, 2020 · 5 comments · Fixed by #1567
Closed

C1-8 controls only report values 0-9 to host now (really: windows w_char sprintfs) #1553

mkruselj opened this issue Feb 5, 2020 · 5 comments · Fixed by #1567
Labels
Host Automation Issues related to DAW (host) automation UI Issues related to UI look&feel Windows Windows related issues
Milestone
1.6.6

Comments

@mkruselj
Copy link
Collaborator

mkruselj commented Feb 5, 2020

It was 0.00-100.00% previously.

Reaper 64-bit VST3.
@mkruselj mkruselj added UI Issues related to UI look&feel Host Automation Issues related to DAW (host) automation labels Feb 5, 2020
@baconpaul
Copy link
Collaborator

Oh shoot; is it the stringification of the value or the actual value in reaper?

@mkruselj
Copy link
Collaborator Author

mkruselj commented Feb 5, 2020

Actual value.

image

@baconpaul baconpaul added this to the 1.6.6 milestone Feb 5, 2020
@baconpaul baconpaul added the Windows Windows related issues label Feb 5, 2020
@baconpaul
Copy link
Collaborator

OK
Of course, it works on mac
Just a quick test. If you put into latch mode, play, and drag the control in the surge ui (not the reaper UI) do you get smooth automation?

@mkruselj
Copy link
Collaborator Author

mkruselj commented Feb 5, 2020

It's smooth - just the param value display is quantized to single digit.

@baconpaul
Copy link
Collaborator

OK! This is the exact same problem that made the controls have the name "C" on windows. Basically more wide string shenanigans. Since the actual tracking is smooth I think we can fix this in 1.6.6 timescale. I know where the problem is and can fix it easily.

Thanks!

@baconpaul baconpaul changed the title C1-8 controls only report values 0-9 to host now C1-8 controls only report values 0-9 to host now (really: windows w_char sprintfs) Feb 6, 2020
baconpaul added a commit to baconpaul/surge that referenced this issue Feb 12, 2020
@baconpaul
Apply the WideHack to CC %
66fe7fb 
The CC % was cursed by the same wierd wide string problem
as the metaparam name. I don't understand why this fix
fixes it, but I also haven't invested enough in windows
wide strings to be too bothered, since this does work.

Closes surge-synthesizer#1553
@baconpaul baconpaul mentioned this issue Feb 12, 2020
Merged
baconpaul added a commit to baconpaul/surge that referenced this issue Feb 12, 2020
@baconpaul
Apply the WideHack to CC %
eb4c3eb 
The CC % was cursed by the same wierd wide string problem
as the metaparam name. I don't understand why this fix
fixes it, but I also haven't invested enough in windows
wide strings to be too bothered, since this does work.

Closes surge-synthesizer#1553
baconpaul added a commit that referenced this issue Feb 12, 2020
@baconpaul
Apply the WideHack to CC % (#1567)
48b6528 
The CC % was cursed by the same wierd wide string problem
as the metaparam name. I don't understand why this fix
fixes it, but I also haven't invested enough in windows
wide strings to be too bothered, since this does work.

Closes #1553
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Host Automation Issues related to DAW (host) automation UI Issues related to UI look&feel Windows Windows related issues
Projects
None yet
Milestone
1.6.6
Development

Successfully merging a pull request may close this issue.

Apply the WideHack to CC % baconpaul/surge
2 participants
@mkruselj @baconpaul