Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve automation param naming of FX units #1540

Closed
mkruselj opened this issue Jan 31, 2020 · 2 comments · Fixed by #1566
Closed

Improve automation param naming of FX units #1540

mkruselj opened this issue Jan 31, 2020 · 2 comments · Fixed by #1566
Labels
Host Automation Issues related to DAW (host) automation
Milestone

Comments

@mkruselj
Copy link
Collaborator

mkruselj commented Jan 31, 2020

Currently (in 1.6.5 release) FX are just named 1-8 in the automation parameter list. It would make more sense to comply (or adapt) to nomenclature that Surge's GUI uses, which is:

A Insert 1
A Insert 2
B Insert 1
B Insert 2
Send FX 1
Send FX 2
Master 1
Master 2

This text shows here:

image

Even this is slightly inconsistent (only Send FX has "FX" in its name, haha), but here's how I would propose condensing the automation parameter names (and then update this text within Surge as well):

IFX A1 Param 1...x
IFX A2 Param 1...x
IFX B1 Param 1...x
IFX B2 Param 1...x
SFX 1 Param 1...x
SFX 2 Param 1...x
MFX 1 Param 1...x
MFX 2 Param 1...x

Note that this numbering is 1-based, currently it's 0-based for 1.6.5.

And then I would also suggest tweaking that text within Surge so that it's consistent:

A Insert FX 1
A Insert FX 2
B Insert FX 1
B Insert FX 2
Send FX 1
Send FX 2
Master FX 1
Master FX 2

@baconpaul baconpaul added this to the 1.6.6 milestone Jan 31, 2020
@baconpaul
Copy link
Collaborator

https://forum.juce.com/t/vst3-parameter-name-changes-dont-work/28313/2

Just dropping that convo there. Vst3 and au have parameter name invalidation available and so we could avail ourselves of them perhaps and even make the name “afx 1 p1 delay time” or what not

@mkruselj mkruselj added the Host Automation Issues related to DAW (host) automation label Feb 5, 2020
baconpaul added a commit to baconpaul/surge that referenced this issue Feb 12, 2020
The FX Automation Param names were a mess. Was FX6 a send or a master?
So use consisnent names in the UI and in the automation params.

Closes surge-synthesizer#1540
@baconpaul
Copy link
Collaborator

Good idea. I chose a slightly different name for the DAW params ("FX A1", "FX A2" "FX S1" etc... ) to keep the list looking close to the current one. Changed the menu. Am pushing now.

Making the VST3 param name update work will make this powerful too. Will see how that works out.

Oh also no longer label params starting at 0 rather use 1.

baconpaul added a commit that referenced this issue Feb 12, 2020
The FX Automation Param names were a mess. Was FX6 a send or a master?
So use consisnent names in the UI and in the automation params.

Closes #1540
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Host Automation Issues related to DAW (host) automation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants