Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feedback on Slider Bar Feature #1499

Closed
baconpaul opened this issue Jan 22, 2020 · 4 comments
Closed

Feedback on Slider Bar Feature #1499

baconpaul opened this issue Jan 22, 2020 · 4 comments

Comments

@baconpaul
Copy link
Collaborator

I just put a slider bar feature in to ship in 1.6.5

Feedback on it from nightly users here please!

final
@baconpaul baconpaul added this to the 1.6.5 milestone Jan 22, 2020
@VincyZed
Copy link
Collaborator

Cool! Will test it.

baconpaul added a commit to baconpaul/surge that referenced this issue Jan 22, 2020
@baconpaul
Respond to user feedback by tighteing green line
57a1a57 
Addresses surge-synthesizer#1499
@baconpaul baconpaul mentioned this issue Jan 22, 2020
Merged
baconpaul added a commit that referenced this issue Jan 22, 2020
@baconpaul
Respond to user feedback by tighteing green line (#1500)
0458d2f 
Addresses #1499
@VincyZed
Copy link
Collaborator

VincyZed commented Jan 22, 2020 •
edited
Loading

3 things I noticed so far:

  • Green line does not update by itself when activating Unipolar when in routing mode. They only do after moving the slider.
  • Vertical green lines have not been narrowed in the latest fix like the horizontal ones.
  • Are envelopes always unipolar? if so, I guess it should be a unipolar green line as well, but I may be mistaken.

@baconpaul
Copy link
Collaborator Author

Oh darn it yea I knew about the first one; and the second is just sloppy. Than you.

Envelopes are always unipolar; but you can modulate an envelope parameter with a bipolar modulator. So when using the AEG or FEG modulator it should appear unipolar; but when modulating the AEG attack with an LFO it should appear bipolar.

baconpaul added a commit to baconpaul/surge that referenced this issue Jan 22, 2020
@baconpaul
Three more "GreenLine" changes
287b4be 
1. Vertical green line is also thin
2. Switting LFO Unipolar switches green line unipolar
3. Bipolar/Unipolar switch while modulating with CC also

Addresses surge-synthesizer#1499
@baconpaul baconpaul mentioned this issue Jan 22, 2020
Merged
baconpaul added a commit that referenced this issue Jan 22, 2020
@baconpaul
Three more "GreenLine" changes (#1502)
57609e2 
1. Vertical green line is also thin
2. Switting LFO Unipolar switches green line unipolar
3. Bipolar/Unipolar switch while modulating with CC also

Addresses #1499
@baconpaul
Copy link
Collaborator Author

Seems we ended up in a good place. Closing this one.

@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@baconpaul @VincyZed