Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pitch wheel in MPE mode is unexpected #1487

Closed
baconpaul opened this issue Jan 16, 2020 · 0 comments · Fixed by #1492
Closed

Pitch wheel in MPE mode is unexpected #1487

baconpaul opened this issue Jan 16, 2020 · 0 comments · Fixed by #1492

Comments

@baconpaul
Copy link
Collaborator

As discussed in #1473

OK so I see the pitchbend problem in MPE mode and it is independent of tuning. Basically in MPE mode channel 0 pitch bend both sets the mpeGlobalPitchBend and the modulation source ms_pitchbend but the second doubles up the application to the pitch (as opposed to just being the modulation source). So in mpe enabled mode we need to make sure that ms_pitchbend is set (in case someone maps a filter to it or whatnot and uses global pitchbend on their MPE device) but does not change the pitch, oddly, since that is done in the MPE voice management.

I'll try and replicate above in unit tests and fix.
@baconpaul baconpaul added the mpe label Jan 16, 2020
@baconpaul baconpaul added this to the 1.6.5 milestone Jan 16, 2020
baconpaul added a commit to baconpaul/surge that referenced this issue Jan 22, 2020
@baconpaul
Fix MPE Pitch Bend with non-MPE devices
7dae5ec 
MPE pitch bend with non-MPE devices would double bend since the
(really unused) MPE global pitch bend got double counted. So make
it just be single counted, and put the fix in place with a regtest.
While at it, add a regtest for non-monotonic tunings and tuning in
the presence of pitch bend.

Closes surge-synthesizer#1489
Closes surge-synthesizer#1487
@baconpaul baconpaul mentioned this issue Jan 22, 2020
Merged
baconpaul added a commit that referenced this issue Jan 22, 2020
@baconpaul
Fix MPE Pitch Bend with non-MPE devices (#1492)
143cfb6 
MPE pitch bend with non-MPE devices would double bend since the
(really unused) MPE global pitch bend got double counted. So make
it just be single counted, and put the fix in place with a regtest.
While at it, add a regtest for non-monotonic tunings and tuning in
the presence of pitch bend.

Closes #1489
Closes #1487
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix MPE Pitch Bend with non-MPE devices baconpaul/surge
1 participant
@baconpaul