Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel split / dual mode swapped when selected #1485

Closed
pauleye opened this issue Jan 16, 2020 · 13 comments · Fixed by #1486
Closed

Channel split / dual mode swapped when selected #1485

pauleye opened this issue Jan 16, 2020 · 13 comments · Fixed by #1486

Comments

@pauleye
Copy link

pauleye commented Jan 16, 2020

Describe the bug
When selecting channel split mode, dual mode shows as selected, and vice versa. Selecting any of the scene A/B, oscillator 1/2/3, or routing buttons updates the selection to the correct one. Any other buttons don't seem to update it.

In the upper part of this image I've selected channel split, and dual in the lower.

surgemodebug

Please let us know your surge version

  • Surge Version: latest nightly, aa92f27 as of now, but it's been going on for a while
  • Plugin type (VST2, 3 or AU): VST2
  • Bits (32/64): both

Desktop (please complete the following information):

  • OS: Windows 10 x64 1909
  • Host: REAPER (32-bit and 64-bit)
  • Version: 6.03 (and a few earlier versions)
  • Also tested in Jeskola Buzz (32-bit) out of interest, same behaviour
@baconpaul baconpaul added this to the 1.6.5 milestone Jan 16, 2020
@baconpaul
Copy link
Collaborator

Thanks. There’s a tricky bit of code which makes the display order and the switch value swap around. I bet I missed a spot. Tagging this 1.6.5 so I can fix before we ship final.

To be clear this is a ui only problem. The synth does the right thing but displays the wrong state yeah?

Appreciate the clear bug report. Thank you

@pauleye
Copy link
Author

pauleye commented Jan 16, 2020

Yep, it's just an UI bug, functionality is as expected :)

@baconpaul
Copy link
Collaborator

Super - thanks! Will definitely fix before 1.6.5. Appreciated!

@baconpaul
Copy link
Collaborator

So both the AU and VST3 on macOS in Logic and Reaper (respectively) do not do this.

I'm on a new laptop so I don't have a VST2 environment up and running yet, nor a windows environment, but do you have the ability to test the VST3 on windows and see if that works? (At this point, the VST3 is generally a better choice than the VST2 in all environments).

@baconpaul
Copy link
Collaborator

(We still have to fix it of course!)

@pauleye
Copy link
Author

pauleye commented Jan 16, 2020

Yeah, the VST3 works as expected (tested the 64-bit version only, same nightly build)
I'm still a bit of a dinosaur who hasn't really moved to VST3 yet at all :D

@baconpaul
Copy link
Collaborator

OK cool but that helps me figure out how to debug

Step 1: Make it so I have any system anywhere that can run the surge vst2 :)

(Brief plug for VST3. In reaper the nightly VST3 has the cool new menu extension feature, by the way. If you RMB on a surge control you will get the reaper param menu right there in surge! Still a few things to work out but it's great. Also if you are on Reaper 6.02 or greater, and the Surge nightly, you get corrected side chain routing for audio processing with surge (which required a joint change to reaper and surge). But we still need to fix the VST2 of course!)

@pauleye
Copy link
Author

pauleye commented Jan 16, 2020

Oh, good to know, thanks :)

@baconpaul
Copy link
Collaborator

Anyway in good news, Mac VST2 does exactly what you report and I can now run it in reaper. (Like I said I'm mid setting up my new laptop so some things take a bit longer. Got it all running).

Will debug and report back.

@pauleye
Copy link
Author

pauleye commented Jan 16, 2020

Sure, take your time :)
Just tested the VST3 RMB menu, that's...a surprise, and certainly useful :D

baconpaul added a commit to baconpaul/surge that referenced this issue Jan 16, 2020
The VST2 when setting a parameter sends automation which loops back
into the ::idle once more than the VST3 and AU do (and I think
improperly) but this meant that the scenemode override for mapping
hack was not applied properly. Fix that with further hacks. But they
are hacks you know.

Closes surge-synthesizer#1485
@baconpaul
Copy link
Collaborator

Found and fixed this. Let me walk it through CI and stuff but should be corrected in the VST2 nightly soon.

I'm not that proud of my fix. but you know, VST2 is old. I'm OK hacking around it a bit.

baconpaul added a commit that referenced this issue Jan 16, 2020
The VST2 when setting a parameter sends automation which loops back
into the ::idle once more than the VST3 and AU do (and I think
improperly) but this meant that the scenemode override for mapping
hack was not applied properly. Fix that with further hacks. But they
are hacks you know.

Closes #1485
@pauleye
Copy link
Author

pauleye commented Jan 16, 2020

Works as expected now, thanks :)

@baconpaul
Copy link
Collaborator

Awesome. Thanks for the super clear report! And have fun making music with Surge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants