Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WM_POINTER rather than WM_GESTURE #1469

Closed
baconpaul opened this issue Jan 10, 2020 · 0 comments · Fixed by #1475
Closed

WM_POINTER rather than WM_GESTURE #1469

baconpaul opened this issue Jan 10, 2020 · 0 comments · Fixed by #1475
Labels
Windows Windows related issues

Comments

@baconpaul
Copy link
Collaborator

From Slack regarding Windows Touch and #1461 and a potential improvement in the future to @nathankopp change (which works and is merged). I agreed with Nathan that it would be better but working is a good next step; so merged the current change. If someone comes along and wants to do a serious bit of work on windows touch in vstgui, this issue will help!

kurasu 2:58 AM
you don't want to use WM_TOUCH or WM_GESTURE, WM_POINTER is where its at

Nathan Kopp 3:59 AM
Just took a look at WM_POINTER. Looks like this replaces WM_GESTURE and WM_TOUCH. Not sure why the MS docs haven't been updated to mention the newer features. Anyway, WM_POINTER also seems like it will take more effort than using WM_GESTURE. The benefit of my current method is that I only pay attention to the gesture-begin and gesture-end messages, and let everything pass through to DefWindowProc(). Then, the default gesture handler converts the touches into mouse events. There are some downsides (such as a "dead zone" around the initial touch point, which is not good if you want to move a slider just a tiny bit), but the benefit is that it requires much less code. I'm going to push my change (since it's working), but if anyone wants to improve things to use WM_POINTER instead, I won't be offended. 🙂

@baconpaul baconpaul added the Windows Windows related issues label Jan 10, 2020
@baconpaul baconpaul added this to the Currently Unscheduled milestone Jan 10, 2020
baconpaul added a commit to baconpaul/surge that referenced this issue Jan 14, 2020
Move the VSTGUI pointer to latest @nathankopp version which
fixes windows touch both on and off touch devices

Closes surge-synthesizer#1470
Closes surge-synthesizer#1469
baconpaul added a commit to baconpaul/surge that referenced this issue Jan 14, 2020
Move the VSTGUI pointer to latest @nathankopp version which
fixes windows touch both on and off touch devices

Closes surge-synthesizer#1470
Closes surge-synthesizer#1469

Also adjust a tolerance on a regtest which woudl fail in the
random envelope stress
baconpaul added a commit that referenced this issue Jan 14, 2020
Move the VSTGUI pointer to latest @nathankopp version which
fixes windows touch both on and off touch devices

Closes #1470
Closes #1469

Also adjust a tolerance on a regtest which woudl fail in the
random envelope stress
@mkruselj mkruselj removed this from the Currently Unscheduled milestone Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Windows Windows related issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants