Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vs2019 and std::filesystem #1433

Closed
baconpaul opened this issue Dec 19, 2019 · 0 comments · Fixed by #1435
Closed

vs2019 and std::filesystem #1433

baconpaul opened this issue Dec 19, 2019 · 0 comments · Fixed by #1435
Labels
Windows Windows related issues

Comments

@baconpaul
Copy link
Collaborator

vs2019 seems to have put std::filesystem in std:: rather than std::experimental

I think this

+#if WINDOWS && ( _MSC_VER >= 1920 )
+// vs2019
+namespace fs = std::filesystem
+#else
 namespace fs = std::experimental::filesystem;
+#endif

is the type of diff we will need. But I want to install vs2019 and try. And it may not work anyway since we force build system to 141 (vs2017).

Tagging @VincyZed

@baconpaul baconpaul added the Windows Windows related issues label Dec 19, 2019
baconpaul added a commit to baconpaul/surge that referenced this issue Dec 19, 2019
VS2019 changed std::experimental::filesystme to std::filesystem
so condition on windows on MSC_VER to use a different name.

Closes surge-synthesizer#1433
baconpaul added a commit that referenced this issue Dec 19, 2019
VS2019 changed std::experimental::filesystme to std::filesystem
so condition on windows on MSC_VER to use a different name.

Closes #1433
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Windows Windows related issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant