Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LFO wave in LFO editor is drawn under the Min and Max lines #1293

Closed
VincyZed opened this issue Nov 15, 2019 · 3 comments · Fixed by #1320
Closed

LFO wave in LFO editor is drawn under the Min and Max lines #1293

VincyZed opened this issue Nov 15, 2019 · 3 comments · Fixed by #1320

Comments

@VincyZed
Copy link
Collaborator

Describe the bug
The LFO wave is drawn under the Minimum and Maximum lines in the LFO editor.

Latest nightly, VST3 x64.

Expected behavior
LFO wave should be drawn over the Minimum and Maximum lines in the LFO editor so it doesn't appear thinner in these areas.

Screenshots
lfo
@baconpaul baconpaul added this to the 1.6.4 milestone Nov 15, 2019
@baconpaul
Copy link
Collaborator

This is just reordering the draw calls in COsicullatorDisplay.cpp. Super easy. Tagging for 1.6.4. Thanks for seeing it!

baconpaul added a commit to baconpaul/surge that referenced this issue Nov 20, 2019
@baconpaul
Draw the LFO after the envelope
b07f5f0 
The LFO oscillator was drawn before the envelope leading to a misdraw
which was visible at high zoom. Just change the order of path draws.

Closes surge-synthesizer#1293
@baconpaul baconpaul mentioned this issue Nov 20, 2019
Merged
@baconpaul
Copy link
Collaborator

Screen Shot 2019-11-20 at 10 12 23 AM

There you go! PR in and headed to nightly now

baconpaul added a commit that referenced this issue Nov 20, 2019
@baconpaul
Draw the LFO after the envelope (#1320)
4fec801 
The LFO oscillator was drawn before the envelope leading to a misdraw
which was visible at high zoom. Just change the order of path draws.

Closes #1293
@VincyZed
Copy link
Collaborator Author

Awesome, thank you!! :)

@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Draw the LFO after the envelope baconpaul/surge
2 participants
@baconpaul @VincyZed