Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uni Spread "Absolute" mode doesn't work in Window and SH-Noise oscillators #1284

Closed
VincyZed opened this issue Nov 10, 2019 · 4 comments · Fixed by #1452
Closed

Uni Spread "Absolute" mode doesn't work in Window and SH-Noise oscillators #1284

VincyZed opened this issue Nov 10, 2019 · 4 comments · Fixed by #1452
Labels
DSP Issues and feature requests related to sound generation in the synth

Comments

@VincyZed
Copy link
Collaborator

VincyZed commented Nov 10, 2019 •
edited
Loading

While playing notes on different octaves in these two OSC modes, they are still being de-tuned proportionally to the notes I play, where as in other OSC modes, in Absolute spreading, the higher the note, the less detuned the voices are from each other (as it should be).

VST3 x64, FL Studio 20.5.1 x64, Windows 10 x64.

I think that this is a pretty old bug, as it was present in a version from last June (and possibly before that as well).
@VincyZed VincyZed changed the title Uni Spread "Absolute Uni Spread "Absolute" mode doesn't work in Window and SH-Noise oscillators Nov 10, 2019
@baconpaul baconpaul added this to the 1.6.4 milestone Nov 11, 2019
@baconpaul baconpaul added the DSP Issues and feature requests related to sound generation in the synth label Nov 11, 2019
@baconpaul
Copy link
Collaborator

Oh yeah. That’s a bug that her been there since I implemented absolute in the summer. When I added absolute mode I bet I didn’t add it to window and S&H just the other oscillators. thanks!

@baconpaul baconpaul modified the milestones: 1.6.4, Currently Unscheduled, 1.6.5 Nov 21, 2019
@baconpaul
Copy link
Collaborator

I'm going to push this out of 1.6.4 for now since I want 1.6.4 to be a bit smaller.

@baconpaul
Copy link
Collaborator

Turns out it is just the window oscillator; S&H is doing the right thing if you set it in correlation=1 mode (where the frequency not the noise shows the pitch).

baconpaul added a commit to baconpaul/surge that referenced this issue Jan 5, 2020
@baconpaul
Support Absolute UNI mode in Window and S&H
824c76c 
The Window and S&H oscillators didn't support Absolute
mode for Unison. So

1. Make a direct load of an FXP availble so we can unit test them
2. Set up unit tests to compare all the uni-featuring oscillators between
   absolute and relative
3. Modify the Window oscillator to obey Absolute, thus making the test pass

Closes surge-synthesizer#1284
@baconpaul baconpaul mentioned this issue Jan 5, 2020
Merged
baconpaul added a commit that referenced this issue Jan 5, 2020
@baconpaul
Support Absolute UNI mode in Window and S&H (#1452)
d24c1b7 
The Window and S&H oscillators didn't support Absolute
mode for Unison. So

1. Make a direct load of an FXP availble so we can unit test them
2. Set up unit tests to compare all the uni-featuring oscillators between
   absolute and relative
3. Modify the Window oscillator to obey Absolute, thus making the test pass

Closes #1284
@VincyZed
Copy link
Collaborator Author

VincyZed commented Jan 5, 2020

Ah yes that's right, Absolute in S&H works fine, just tested as well. Awesome!

@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DSP Issues and feature requests related to sound generation in the synth
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support Absolute UNI mode in Window and S&H baconpaul/surge
2 participants
@baconpaul @VincyZed