Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resetting modulation amount of release velocity by double-clicking on a blue slider doesn't work correctly #1272

Closed
VincyZed opened this issue Nov 2, 2019 · 2 comments · Fixed by #1273
Closed

Resetting modulation amount of release velocity by double-clicking on a blue slider doesn't work correctly #1272

VincyZed opened this issue Nov 2, 2019 · 2 comments · Fixed by #1273

Comments

@VincyZed
Copy link
Collaborator

VincyZed commented Nov 2, 2019

Bug description
Double-clicking to reset a blue slider (modulation amount) that is linked to release velocity doesn't actually reset the mod amount value.

Surge Version
Latest nightly, VST3 64 bits.

Steps to reproduce the behavior

  1. Open stock patch of Surge.
  2. Select Velocity in the routing bar.
  3. Switch to release velocity
  4. Engage routing mode
  5. Drag OSC Pitch's blue slider all the way, for example. (increase AEG release to hear the effect)
  6. Double-click on the blue slider to reset it to 0. On screen it goes back to center, but it is still being modulated.
  7. Disengage, then re-engage routing mode. The slider will be back to where it was before.

Expected behavior
Double-clicking should reset the modulation amount to 0 correctly.
@baconpaul
Copy link
Collaborator

What's happening is the double-click is resetting the UI element (great!) and the velocity modulation (only half great). The only half great is because with release velocity selected you want to reset that modulation.

Excellent bug report. Should be able to squash it shortly.

baconpaul added a commit to baconpaul/surge that referenced this issue Nov 3, 2019
@baconpaul
Fix double-click reset mapping in release mode
1b2ebb3 
In Release Mode the double-click mapping for resetting a modulation
vecoted to Velocity still. Use the 'thisms' trick to look up the
alternate from my gui element.

Closes surge-synthesizer#1272
@baconpaul baconpaul mentioned this issue Nov 3, 2019
Merged
@baconpaul
Copy link
Collaborator

Found and fixed it in literally 7 minutes with this bug report. Thanks! Sweep coming.

baconpaul added a commit that referenced this issue Nov 3, 2019
@baconpaul
Fix double-click reset mapping in release mode (#1273)
c673228 
In Release Mode the double-click mapping for resetting a modulation
vecoted to Velocity still. Use the 'thisms' trick to look up the
alternate from my gui element.

Closes #1272
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix double-click reset mapping in release mode baconpaul/surge
2 participants
@baconpaul @VincyZed