Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sine osc: WaveShape > Shape #1147

Closed
mkruselj opened this issue Sep 10, 2019 · 2 comments · Fixed by #1148
Closed

Sine osc: WaveShape > Shape #1147

mkruselj opened this issue Sep 10, 2019 · 2 comments · Fixed by #1148
Milestone
1.6.2

Comments

@mkruselj
Copy link
Collaborator

I feel there shouldn't be random naming inconsistencies like these. Classic oscillator uses Shape, so why shouldn't the Sine oscillator use the same parameter name? :)
@baconpaul baconpaul added this to the 1.6.2 milestone Sep 10, 2019
@baconpaul
Copy link
Collaborator

That is an excellent point and an easy change.

@VincyZed I’m gonna make this change for 1.6.2 in case that requires a quick mannual edit.

@VincyZed
Copy link
Collaborator

Yes, I agree, and it will be changed in the manual. Thanks for letting me know!

baconpaul added a commit to baconpaul/surge that referenced this issue Sep 10, 2019
@baconpaul
Rename Sin "WaveShape" to "Shape"
ebab95f 
Classic uses "Shape" for the waveshape. So should Sine.

Closes surge-synthesizer#1147
@baconpaul baconpaul mentioned this issue Sep 10, 2019
Merged
baconpaul added a commit that referenced this issue Sep 10, 2019
@baconpaul
Rename Sin "WaveShape" to "Shape" (#1148)
ba36b33 
Classic uses "Shape" for the waveshape. So should Sine.

Closes #1147
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.6.2
Development

Successfully merging a pull request may close this issue.

Rename Sin "WaveShape" to "Shape" baconpaul/surge
3 participants
@mkruselj @baconpaul @VincyZed