Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zenity linux doesn't get mouse focus #1124

Closed
baconpaul opened this issue Sep 5, 2019 · 8 comments · Fixed by #1125
Closed

zenity linux doesn't get mouse focus #1124

baconpaul opened this issue Sep 5, 2019 · 8 comments · Fixed by #1125

Comments

@baconpaul
Copy link
Collaborator

Reported by @tank-trax and @mortfell to @jpcima and me any of the zenity things like open sci no longer respond to mouse

I bet our menu changes mean a mouse event is getting mis-routed or mis-handled and vstgui is somehow confused about who has focus.

@baconpaul
Copy link
Collaborator Author

So here's the problem

It used to be a menu closed before a callback was called

With our never animate that is no longer the case

So the menu is still open and stealing the mouse

Basically the lack of animation in removeModalView gets things out of order.

@jpcima
Copy link
Contributor

jpcima commented Sep 5, 2019

Oh right. What if the callback is rescheduled on the event loop to be done soon later?
eg. on a 0-delay timer

@baconpaul
Copy link
Collaborator Author

Yeah that's exactly the fix. I will get it in place now.

baconpaul added a commit to baconpaul/surge that referenced this issue Sep 5, 2019
@tank-trax
Copy link
Collaborator

basically the whole screen becomes mouse inoperable... keyboard works though; happens on all versions LV2, VST2 and VST3

surge-zenity 01

@baconpaul
Copy link
Collaborator Author

Yeah I found the bug and have a fix. Just waiting for CI to finish and I'll merge it. Thanks!!

baconpaul added a commit that referenced this issue Sep 5, 2019
@baconpaul
Copy link
Collaborator Author

just pushed to master. If you build yourself and do a submodule update you should be good. Or wait for the deb in about 30 minutes.

@jpcima
Copy link
Contributor

jpcima commented Sep 5, 2019

It confirm it as fixed after rebuilding master, following the submodule update.

@baconpaul
Copy link
Collaborator Author

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants