Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Versions for 162 #1116

Closed
baconpaul opened this issue Sep 5, 2019 · 2 comments · Fixed by #1130
Closed

Versions for 162 #1116

baconpaul opened this issue Sep 5, 2019 · 2 comments · Fixed by #1130
Milestone
1.6.2

Comments

@baconpaul
Copy link
Collaborator

baconpaul commented Sep 5, 2019 •
edited
Loading

  1. As @gnips reports there’s a version in the windows rc
    2. Wanna change info.plist so parent display name is surge synth team (but keep Id at vm a) to match the effect bank
@baconpaul baconpaul added this to the 1.6.2 milestone Sep 5, 2019
@baconpaul
Copy link
Collaborator Author

The AU one is a bit trickier so I'm gonna leave that be for 1.6.2. The au is a bit of a mess overall actually in a couple of ways (files in the wrong spot and so on). So maybe when I undertake experimental/ branch I'll add that to the list...

@baconpaul
Copy link
Collaborator Author

So version numbers live in

  • src/common/surge_auversion.h
  • resource/osx-*/Info.plist
  • src/windows/surge.rc (in several places in for 1,6,0,0)
  • src/common/version.h

src/common/version.h also contains a copyright year as does the AU info.plist

So I'll close this issue when

  1. I've written a "doc/versionnumbers.md" outlining this
  2. I've updated them all

Bit tedious for a saturday morning but want to make sure to get to it.

@baconpaul baconpaul changed the title Names and versions for 162 Versions for 162 Sep 7, 2019
baconpaul added a commit to baconpaul/surge that referenced this issue Sep 7, 2019
@baconpaul
Move Version Numbers to 1.6.2
a762772 
Ahead of the 1.6.2 release, move the DLL and Plugin version
nubmers from 1.6.0 (since we had never moved these before)
to 1.6.2. Also add a doc on where they all live.

Closes surge-synthesizer#1116
baconpaul added a commit to baconpaul/surge that referenced this issue Sep 7, 2019
@baconpaul
Move Version Numbers to 1.6.2
8b2deab 
Ahead of the 1.6.2 release, move the DLL and Plugin version
nubmers from 1.6.0 (since we had never moved these before)
to 1.6.2. Also add a doc on where they all live.

Closes surge-synthesizer#1116
@baconpaul baconpaul mentioned this issue Sep 7, 2019
Merged
baconpaul added a commit to baconpaul/surge that referenced this issue Sep 7, 2019
@baconpaul
Move Version Numbers to 1.6.2
5bd21db 
Ahead of the 1.6.2 release, move the DLL and Plugin version
nubmers from 1.6.0 (since we had never moved these before)
to 1.6.2. Also add a doc on where they all live.

Closes surge-synthesizer#1116
baconpaul added a commit that referenced this issue Sep 7, 2019
@baconpaul
Move Version Numbers to 1.6.2 (#1130)
3df2128 
Ahead of the 1.6.2 release, move the DLL and Plugin version
nubmers from 1.6.0 (since we had never moved these before)
to 1.6.2. Also add a doc on where they all live.

Closes #1116
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.6.2
Development

Successfully merging a pull request may close this issue.

Move Version Numbers to 1.6.2 baconpaul/surge
1 participant
@baconpaul