Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Longer one-shots crashing VST3i and VSTi on Windows 10 #1087

Closed
mortfell opened this issue Sep 1, 2019 · 2 comments · Fixed by #1091
Closed

Longer one-shots crashing VST3i and VSTi on Windows 10 #1087

mortfell opened this issue Sep 1, 2019 · 2 comments · Fixed by #1091
Labels
Audio Formats
Milestone
1.6.2

Comments

@mortfell
Copy link

mortfell commented Sep 1, 2019

I've tried loading one-shots in the past, and noticed there was a size limit.
The other day I noticed that in a recent version of Surge we can now import longer Wavs as one-shots. Tried this on Mac and it worked fine.
Loading longer one-shots on Windows however.... crashes Reaper and Ableton Live .

One-shots of the size which previously worked is fine, but larger ones crash instantly.
As examples:
this still works fine on windows and mac:
poor lil guy.zip
this crashes on windows:
Snare-VSCO.zip

I'm using the latest nightly (Aug 29 2019)
REAPER and Ableton Live
VSTi and VST3i
Windows 10 64 bit

I'm not getting any error or anything, instant crash
If there is anything else I can do to provide better info let me know!
@baconpaul baconpaul added this to the 1.6.2 milestone Sep 1, 2019
@baconpaul
Copy link
Collaborator

Thanks - bet it will be easy to find. I’ll look this week

baconpaul added a commit to baconpaul/surge that referenced this issue Sep 1, 2019
@baconpaul
Re-allocation using samples caused Crash; Fix
c67f48a 
Re-allocating larger wavetables in some very specific size
cases mis-allocated the size required for the silence which
was appended. This left memory mis-aligned causing an immediate
crash on Windows in some cases. Fix by adding the silence pad to the
required size for a given set of tables.

Closes surge-synthesizer#1087
@baconpaul baconpaul mentioned this issue Sep 1, 2019
Merged
@baconpaul
Copy link
Collaborator

You know how I always say "good bug reports make good software"? Well I think I'll print that on a friggin mug after this one. The particular edge case here doesn't matter that much, except that it was only a small set of .wav files which would have caught it in quite the way you found here, and order of operation matters, and your case was a great reproduction.

Anyway the 17 character (!!) fix is making its way through the pull request and CI process now.

Thank you for this report.

baconpaul added a commit that referenced this issue Sep 1, 2019
@baconpaul
Re-allocation using samples caused Crash; Fix (#1091)
cdeac1f 
Re-allocating larger wavetables in some very specific size
cases mis-allocated the size required for the silence which
was appended. This left memory mis-aligned causing an immediate
crash on Windows in some cases. Fix by adding the silence pad to the
required size for a given set of tables.

Closes #1087
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Audio Formats
Projects
None yet
Milestone
1.6.2
Development

Successfully merging a pull request may close this issue.

Re-allocation using samples caused Crash; Fix baconpaul/surge
2 participants
@mortfell @baconpaul