Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FX get a chance with old streaming versions to override #1037

Closed
baconpaul opened this issue Aug 17, 2019 · 0 comments · Fixed by #1072
Closed

FX get a chance with old streaming versions to override #1037

baconpaul opened this issue Aug 17, 2019 · 0 comments · Fixed by #1072
Milestone

Comments

@baconpaul
Copy link
Collaborator

Soo #1035 and the oscillator handleStreamingMIsmatches method. Do that for FX. This is more a "bacon paul reminder to self" than a description of the bug.

@baconpaul baconpaul added this to the 1.6.2 milestone Aug 17, 2019
baconpaul added a commit to baconpaul/surge that referenced this issue Aug 17, 2019
This commit sets up a display of statuses in the synth so we
can bring to the front thigns like MPE and Tuning and bind the
menus more comprehensively. It also brings to bear the ability
(optionally) to store a tuning in a patch and the correct state
machine for what to do when loading a patch with tuning with
tuning active.

It almost completely addresses the remainder of surge-synthesizer#828
Addresses the streaming incompatability in surge-synthesizer#1035

Still outstanding is optionally a "lock" and to apply
the streaming version option to FX (which is surge-synthesizer#1037)

Handle streaming revision parameter set changes in OSCes. Deals with
baconpaul added a commit that referenced this issue Aug 17, 2019
This commit sets up a display of statuses in the synth so we
can bring to the front thigns like MPE and Tuning and bind the
menus more comprehensively. It also brings to bear the ability
(optionally) to store a tuning in a patch and the correct state
machine for what to do when loading a patch with tuning with
tuning active.

It almost completely addresses the remainder of #828
Addresses the streaming incompatability in #1035

Still outstanding is optionally a "lock" and to apply
the streaming version option to FX (which is #1037)

Handle streaming revision parameter set changes in OSCes. Deals with
baconpaul added a commit to baconpaul/surge that referenced this issue Aug 21, 2019
With streaming version 11 (version 1.6.2) when I added parameters
to Vocoder and Sine we realized old patches had streamed nonsense
values for those new parameters. So add an opportunity along with
streaming version to reset my values to defaults.

To test this, load any of the vocoder patches in the system and see
that bands == 20 and so on.

Closes surge-synthesizer#1037
baconpaul added a commit that referenced this issue Aug 21, 2019
With streaming version 11 (version 1.6.2) when I added parameters
to Vocoder and Sine we realized old patches had streamed nonsense
values for those new parameters. So add an opportunity along with
streaming version to reset my values to defaults.

To test this, load any of the vocoder patches in the system and see
that bands == 20 and so on.

Closes #1037
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant