Skip to content

Commit

Permalink
Extend COMB size by 2x; Make extension cmake option (#7176)
Browse files Browse the repository at this point in the history
1. The comb size is 2x larger allowing lower resonant
   physical modelling with the comb
2. Since this uses more memory, allow a build time flag
   to turn it off.  -DSST_FILTERS_COMB_EXTENSION_FACTOR=1
   will revert to 1.2; =4 will give you even more modelling.
   =3 will crash and burn horribly. Pick a power of 2 if you
   use this!

Closes #7172
  • Loading branch information
baconpaul authored Aug 12, 2023
1 parent 58288a8 commit aa46018
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
2 changes: 1 addition & 1 deletion libs/sst/sst-filters
6 changes: 6 additions & 0 deletions src/common/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,12 @@ target_compile_definitions(${PROJECT_NAME} PRIVATE
JUCE_STANDALONE_APPLICATION=0
)

if (SST_FILTERS_COMB_EXTENSION_FACTOR)
message(STATUS "Overriding comb extension factor to ${SST_FILTERS_COMB_EXTENSION_FACTOR}")
target_compile_definitions(${PROJECT_NAME} PUBLIC
SST_FILTERS_COMB_EXTENSION_FACTOR=${SST_FILTERS_COMB_EXTENSION_FACTOR})
endif()

target_include_directories(${PROJECT_NAME} PUBLIC
${CMAKE_CURRENT_SOURCE_DIR}
dsp
Expand Down

0 comments on commit aa46018

Please sign in to comment.