More Linux Fixes (#1938)

1. Pipeline to 18.04
2. Fix the sprintf errors
3. Upgrade vstgui in high-rect mode to be faster, closing #1103 again

azure-pipelines.yml

@@ -27,11 +27,11 @@ jobs:
         imageName: 'vs2017-win2016'
         isWindowsUnitTest: True
       linux-lv2:
-        imageName: 'ubuntu-16.04'
+        imageName: 'ubuntu-18.04'
         isLinux: True
         linuxProject: lv2
       linux-vst3:
-        imageName: 'ubuntu-16.04'
+        imageName: 'ubuntu-18.04'
         isLinux: True
         linuxProject: vst3
       linux-unittest:

src/common/Parameter.cpp

@@ -1092,7 +1092,7 @@ void Parameter::get_display_alt(char* txt, bool external, float ef)
       int oct_offset = 1;
       if (storage)
          oct_offset = Surge::Storage::getUserDefaultValue(storage, "middleC", 1);
-      char notename[8];
+      char notename[16];
       sprintf(txt, "%s", get_notename(notename, i_value, oct_offset));
 
       break;
@@ -1106,7 +1106,7 @@ void Parameter::get_display_alt(char* txt, bool external, float ef)
       int oct_offset = 1;
       if (storage)
          oct_offset = Surge::Storage::getUserDefaultValue(storage, "middleC", 1);
-      char notename[8];
+      char notename[16];
       sprintf(txt, "%s", get_notename(notename, i_value, oct_offset));
 
       break;
@@ -1291,7 +1291,7 @@ void Parameter::get_display(char* txt, bool external, float ef)
          int oct_offset = 1;
          if (storage)
             oct_offset = Surge::Storage::getUserDefaultValue(storage, "middleC", 1);
-         char notename[8];
+         char notename[16];
          sprintf(txt, "%s", get_notename(notename, val.i, oct_offset));
          break;
       }

src/common/gui/CNumberField.cpp

@@ -333,7 +333,7 @@ void CNumberField::draw(CDrawContext* pContext)
       int oct_offset = 1;
       if (storage)
          oct_offset = Surge::Storage::getUserDefaultValue(storage, "middleC", 1);
-      char notename[8];
+      char notename[16];
       sprintf(the_text, "%s", get_notename(notename, i_value, oct_offset));
    }
    break;

src/common/gui/SurgeGUIEditor.cpp

@@ -745,6 +745,11 @@ void SurgeGUIEditor::refresh_mod()
    }
    // ctnvg	frame->redraw();
    // frame->setDirty();
+#if LINUX
+   frame->invalid();
+   // Turns out linux is very bad with lots of little invalid rects in vstgui
+   // see github issue 1103
+#endif
 }
 
 int32_t SurgeGUIEditor::onKeyDown(const VstKeyCode& code, CFrame* frame)
@@ -5048,7 +5053,7 @@ R"HTML(
        {
           int oct_offset = 1;
              oct_offset = Surge::Storage::getUserDefaultValue(&(this->synth->storage), "middleC", 1);
-          char notename[8];
+          char notename[16];
 
           std::string rowstyle="";
           std::string tdopen="<td colspan=2>";