Skip to content

Commit

Permalink
Remove PPQ advance check in looping mode (#5865)
Browse files Browse the repository at this point in the history
I confused 'isLooping' to mean "is looping" when it actually
means "would be looping if playing" which meant my ppqpos
reset was improper.

Closes #5812
  • Loading branch information
baconpaul authored Feb 6, 2022
1 parent be6dcac commit 0ee3b2b
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/surge-xt/SurgeSynthProcessor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,8 @@ void SurgeSynthProcessor::processBlock(juce::AudioBuffer<float> &buffer,
playhead->getCurrentPosition(cp);
surge->time_data.tempo = cp.bpm;

if (cp.isPlaying || cp.isRecording || cp.isLooping)
// isRecording should always imply isPlaying but better safe than sorry
if (cp.isPlaying || cp.isRecording)
surge->time_data.ppqPos = cp.ppqPosition;

surge->time_data.timeSigNumerator = cp.timeSigNumerator;
Expand Down

0 comments on commit 0ee3b2b

Please sign in to comment.