Unison as single voice #1422
Merged
Unison as single voice #1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unison used to be implemented in the voice manager as spanning voices but for a varieyt of reasons (including but not limited to polyphony) you kinda want them stacked before a single processor chain. So move Unison from voice-cretion to bundle-of-generators in-the-voice pattern.
| if (useOversampling) | ||
| for (auto i = 0; i < numGeneratorsActive; ++i) | ||
| GD[i].ratio = GD[i].ratio >> 1; | ||
| fpitch -= 69; |
There was a problem hiding this comment.
Correction factor or debug offset? 🤣
There was a problem hiding this comment.
It’s a 440 vs an 8.12 convention (which is a mess in surge because the function names are the same). But the same offset was in the single generator case outside the loop above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unison used to be implemented in the voice manager as spanning voices but for a varieyt of reasons (including but not limited to polyphony) you kinda want them stacked before a single processor chain. So move Unison from voice-cretion to bundle-of-generators in-the-voice pattern.