Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Voice Termination Fades #801

Closed
baconpaul opened this issue Feb 28, 2024 · 0 comments · Fixed by #1414
Closed

Voice Termination Fades #801

baconpaul opened this issue Feb 28, 2024 · 0 comments · Fixed by #1414

Comments

@baconpaul
Copy link
Contributor

baconpaul commented Feb 28, 2024 •
edited
Loading

in #800 I added a bunch of voice termination on structural changes things

right now this just slams the voice closed. Would be nice if there was a fadeout but that means the voice has to go somewhere to fade and its zone is now no longer configured properly.

One thing we could do is, like, render the voice for 6 blocks into a voice buffer put the voice pointer in an engine wide 'orphaned voice winddown' list have engine process mix that in i guess but then we skip loads of things like processors and busses so it kinda doesn't work.

alternative is voice termination isn't instant; we mark a zone for move or delete n blocks later and so on and then have all the structural messages be async.

it's a hard problem.
@baconpaul baconpaul changed the title Voice Termination Voice Termination Fades Feb 28, 2024
baconpaul added a commit to baconpaul/shortcircuit-xt that referenced this issue Oct 9, 2024
@baconpaul
Voice Stealing and Termination Improvements
6912bd9 
Handle a voice stealing API which, for now, steals only at
the hard limit, but has been tested at both hard and soft
limit at this commit with a different configuration. Closes

At the same time, add a voice termination fade for soft
terminates which keeps the voice alive for 8 blocks with
a fade during the period. Closes surge-synthesizer#801
@baconpaul baconpaul mentioned this issue Oct 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Voice Stealing and Termination Improvements baconpaul/shortcircuit-xt
1 participant
@baconpaul