Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Natural sort menu entries where needed #1185

Closed
mkruselj opened this issue Aug 25, 2024 · 2 comments · Fixed by #1216
Closed

Natural sort menu entries where needed #1185

mkruselj opened this issue Aug 25, 2024 · 2 comments · Fixed by #1216
Labels
UI Issues related to UI look&feel
Milestone
Shortcircuit XT 1.0

Comments

@mkruselj
Copy link
Collaborator

For example here:

image
@mkruselj mkruselj added the UI Issues related to UI look&feel label Aug 25, 2024
@mkruselj mkruselj added this to the SCXT 1.0 milestone Aug 25, 2024
@baconpaul
Copy link
Contributor

Yeah we actually don’t want to strnat those but want to sort them by the target index (which will have the same effect in this case) just in case anyone other than me hops in to do this

@baconpaul
Copy link
Contributor

These sorts are also server side so the fix goes here

shortcircuit-xt/src/modulation/voice_matrix.cpp

Line 213 in fa91e96

const auto &ta = a.first;

baconpaul added a commit to baconpaul/shortcircuit-xt that referenced this issue Aug 29, 2024
@baconpaul
Mapping Constraints and Self Mod Sort
13b2e3a 
Mapping constraints (1) are hard on drag and (2) reject
inversions in the typeins, Closes surge-synthesizer#761

The self-modulation list in the mod pane is now sorted by
index. Closes surge-synthesizer#1185
@baconpaul baconpaul mentioned this issue Aug 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
UI Issues related to UI look&feel
Projects
None yet
Milestone
Shortcircuit XT 1.0
Development

Successfully merging a pull request may close this issue.

Mapping Constraints and Self Mod Sort baconpaul/shortcircuit-xt
2 participants
@mkruselj @baconpaul