Some fixes when switching legato or reordering grup letago (#1462)

there was a bug in VM basically which made the legato application order of group dependent in one case. Fix that and also make sure that swithcing to poly actually switches us to poly (which wasnt that bug but could have been)
surge-synthesizer · Nov 24, 2024 · 349b3c1 · 349b3c1
1 parent 6ccc3bf
commit 349b3c1
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/libs/sst/sst-voicemanager b/libs/sst/sst-voicemanager
diff --git a/src/engine/engine_voice_responder.cpp b/src/engine/engine_voice_responder.cpp
@@ -236,6 +236,8 @@ void Engine::VoiceManagerResponder::setPolyphonicAftertouch(voice::Voice *v, int
 
 void Engine::VoiceManagerResponder::terminateVoice(voice::Voice *v)
 {
+    SCLOG_IF(voiceResponder, "terminateVoice " << v << " " << (int)v->key);
+    ;
     if (!v->isVoicePlaying)
         return;
     if (v->isGated)

diff --git a/src/engine/group.cpp b/src/engine/group.cpp
@@ -624,10 +624,16 @@ void Group::resetPolyAndPlaymode(engine::Engine &e)
     }
     else
     {
+        auto pgrp = (uint64_t)this;
+        SCLOG_IF(voiceResponder, "Setting up poly group " << pgrp);
+
+        e.voiceManager.setPlaymode(pgrp, Engine::voiceManager_t::PlayMode::POLY_VOICES,
+                                   outputInfo.vmPlayModeFeaturesInt);
         assert(outputInfo.vmPlayModeInt == (uint32_t)Engine::voiceManager_t::PlayMode::POLY_VOICES);
         if (!outputInfo.hasIndependentPolyLimit)
         {
             // TODO we really want a 'clear'
+            e.voiceManager.setPolyphonyGroupVoiceLimit((uint64_t)this, maxVoices);
         }
         else
         {
+55 −35		include/sst/voicemanager/voicemanager_impl.h
+48 −0		tests/legato_playback.cpp
+6 −3		tests/test_player.h