Add LP/HP/BP to the BitCrusher effect filter (#1054)

Along the way, add json int param enablement capability, and make multiswitch obey isenabled
surge-synthesizer · Jul 29, 2024 · 2469484 · 2469484
1 parent be73182
commit 2469484
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 5 deletions.
diff --git a/libs/sst/sst-effects b/libs/sst/sst-effects
diff --git a/libs/sst/sst-jucegui b/libs/sst/sst-jucegui
diff --git a/src-ui/components/multi/ProcessorPane.cpp b/src-ui/components/multi/ProcessorPane.cpp
@@ -632,6 +632,16 @@ bool ProcessorPane::layoutControlsFromJSON(const std::string &jsonpath,
                 lw->setJustification(juce::Justification::centred);
                 otherEditors.push_back(std::move(lw));
             }
+
+            auto ei = ictag("enable-if", -1);
+            if (ei >= 0)
+            {
+                if (ei == c.index)
+                {
+                    SCLOG("WARNING: Enable-if set to self on component " << c.index);
+                }
+                intEditors[c.index]->item->setEnabled(intAttachments[ei]->getValue());
+            }
         }
         else if (c.index < 0)
         {

diff --git a/src-ui/json-layout/processors/bitcrusher.json b/src-ui/json-layout/processors/bitcrusher.json
@@ -36,7 +36,7 @@
         {
             "index": 3,
             "coordinates": [
-                40,
+                70,
                 80,
                 50,
                 50
@@ -46,7 +46,7 @@
         {
             "index": 4,
             "coordinates": [
-                100,
+                130,
                 80,
                 50,
                 50
@@ -58,11 +58,23 @@
             "component": "power",
             "index": 0,
             "coordinates": [
-                100,
+                130,
                 80,
                 50,
                 50
             ]
+        },
+        {
+            "type": "int",
+            "component": "multiswitch",
+            "index": 1,
+            "coordinates": [
+                10,
+                80,
+                50,
+                50
+            ],
+            "enable-if": 0
         }
     ]
 }
+17 −0		.github/workflows/code-checks.yml
+2 −1		CMakeLists.txt
+24 −4		include/sst/voice-effects/distortion/BitCrusher.h
+0 −0		libs/catch2/catch2.hpp
+36 −0		.github/workflows/build-pr.yml
+17 −0		.github/workflows/code-checks.yml
+0 −54		.github/workflows/feature.yml
+16 −4		src/sst/jucegui/components/MultiSwitch.cpp