Cleanup/drop scanner stuff #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarCloud Quality Gate failed.
|
|
https://github.com/fopina/scanner-httpx ready to be transferred once this is renamed sonarcloud and codeql workflows disabled (via UI) |
gsilvapt
approved these changes
Apr 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#28 was used to compare this fork with upstream and remove all scanner-related changes from the repo, leaving only the httpx improvements (and fork references).
This is so we can move away from implementing the scanner in a fork and to the normal binary wrapper that we use in every other scanner.
Plan:
httpx(dropscanner-)scanner-httpxproject using structure similar to https://github.com/fopina/scanner-subfinder/