feat: (observability): trace Database.runTransactionAsync

Extracted out of PR googleapis#2158, this change traces Database.runTransactionAsync. Updates googleapis#2079
surbhigarg92 · Oct 21, 2024 · 4d7b0aa · 4d7b0aa
1 parent c597b74
commit 4d7b0aa
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/observability-test/database.ts b/observability-test/database.ts
@@ -1687,7 +1687,7 @@ describe('Database', () => {
         'Unexpected span status message'
       );
 
-      const expectedEventNames = ['Using Session', 'exception'];
+      const expectedEventNames = ['Using Session'];
       assert.deepStrictEqual(
         actualEventNames,
         expectedEventNames,

diff --git a/observability-test/spanner.ts b/observability-test/spanner.ts
@@ -473,7 +473,7 @@ describe('EndToEnd', () => {
         database.formattedName_
       );
       await database.runTransactionAsync(async transaction => {
-        await transaction!.run('SELECT 1');
+        const [rows] = await transaction!.run('SELECT 1');
       });
 
       traceExporter.forceFlush();

diff --git a/src/database.ts b/src/database.ts
@@ -3395,7 +3395,7 @@ class Database extends common.GrpcServiceObject {
             try {
               return await runner.run();
             } catch (e) {
-              setSpanErrorAndException(span, e as Error);
+              setSpanError(span, e as Error);
               throw e;
             } finally {
               span.end();