Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Problems 05-05-21 #107

Merged
merged 57 commits into from
May 8, 2021
Merged

New Problems 05-05-21 #107

merged 57 commits into from
May 8, 2021

Conversation

dankelly01
Copy link
Collaborator

PR Checklist

  • - Latest master branch merged
  • - PR title descriptive (can be used in release notes)

Description

Two new problems for Maths Clubs App.

Git Issues

Closes #

Screenshots/Videos

If useful, provide screenshot or capture to highlight main changes

@github-actions
Copy link

github-actions bot commented Mar 9, 2021

Visit the preview URL for this PR (updated for commit 2f07132):

https://sami-maths-club--pr107-master-ftmi1n6c.web.app

(expires Mon, 07 Jun 2021 16:45:46 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@@ -0,0 +1,25 @@
---
title: MiniMax Algorithm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the title will be converted into a slug and used to reference the markdown file, so MiniMax Algorithm => minimax-algorithm which doesn't match the filename. So please update to just be Minimax (you can still keep the display title in the markdown as Minimax Algorithm, this one is just for metadata extraction)


Try to find the smallest number of different colours which you need to be able to do this.

What about other maps, can you find a certain number of colours which are able to colour in any map?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you maybe add a small example of a correctly coloured and incorrectly coloured group of sections (doesn't have to be the full image, could just be a small part of it)?

Also perhaps you could add a comment to say - "If you don't have colours, you can try shading in different ways such as with dots, crosses or stripes"
(this could be useful in schools were students only have access to paper and pencil, or perhaps a teacher using a chalkboard with only white chalk)

@chrismclarke chrismclarke self-requested a review March 9, 2021 23:49
Copy link
Member

@chrismclarke chrismclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these!

The Colour theorem problem looks great, I really like how accessible you've made it and the extension link to graphs. I've just added a better preview system so you can see a live preview from your code in the app (link in the comments above - which should also refresh if you push any more changes). I've added a couple of small comments inline for some extra info.

The minimax problem isn't running properly for me as it needs the metadata title to match up with the filename (see comment inline), so if you could also make that small update then I can also check that one (the update link should also build the new preview which you can check, usually takes around 5-10 mins).

title: Colouring Maps
type: problem
printOrder: n/a
added: 2021-01
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to change both problems added to 2021-03, just to make sure they take top priority in the app

@dankelly01 dankelly01 changed the title "MiniMax" and "Colouring Maps" Problems New Problems 05-05-21 May 5, 2021
@chrismclarke
Copy link
Member

Looks really great, thanks again for taking the time to add these. Now merging and will create a release to go live over the next week!

@chrismclarke chrismclarke merged commit 7328803 into supportingami:master May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants